From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH] memcg: fix memcg_cache_name() to use cgroup_name() Date: Thu, 28 Mar 2013 11:22:27 +0400 Message-ID: <5153EFB3.5070002@parallels.com> References: <1364373399-17397-1-git-send-email-mhocko@suse.cz> <20130327161527.GA7395@htj.dyndns.org> <20130327161905.GN16579@dhcp22.suse.cz> <20130327162707.GO16579@dhcp22.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130327162707.GO16579@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: Tejun Heo , Li Zefan , KAMEZAWA Hiroyuki , Johannes Weiner , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org On 03/27/2013 08:27 PM, Michal Hocko wrote: > On Wed 27-03-13 09:21:02, Tejun Heo wrote: >> On Wed, Mar 27, 2013 at 9:19 AM, Michal Hocko wrote: >>>> Maybe the name could signify it's part of memcg? >>> >>> kmem_ prefix is used for all CONFIG_MEMCG_KMEM functions. I understand >>> it clashes with sl?b naming but this is out of scope of this patch IMO. >> >> Oh, it's not using kmemcg? I see. Maybe we can rename later. > > Some parts use memcg_kmem_* other kmem_. A cleanup would be nice. > Glauber? > I have been using kmem_ only in functions that will deal directly with the slab caches and with the single purpose of operating them. kmem_cache_destroy_work_func => worker interface to kmem_cache_destroy kmem_cache_destroy_memcg_children => cache destructor iterator kmem_cache_dup => interface to kmem_cache_create All the other functions start with memcg_ Analogously, all slab-side functions that deal with memcg *ends* with _memcg. except the functions that are only there to operate memcg data structures: memcg_update_all_caches. In general, those functions could very well live in the other file (slab or memcg), but they need to take locks or manipulate data structures that are internal to slab/memcg. I believe this is a sound convention.