Re: [PATCH] memcg: don't do cleanup manually if mem_cgroup_css_online() fails

Li Zefan
2013-04-02T08:03:57Z

On 2013/4/2 15:35, Li Zefan wrote:
> If memcg_init_kmem() returns -errno when a memcg is being created,
> mem_cgroup_css_online() will decrement memcg and its parent's refcnt,

> (but strangely there's no mem_cgroup_put() for mem_cgroup_get() called
> in memcg_propagate_kmem()).

The comment in memcg_propagate_kmem() suggests it knows mem_cgroup_css_free()
will be called in failure, while mem_cgroup_css_online() doesn't know.

>
> But then cgroup core will call mem_cgroup_css_free() to do cleanup...
>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
> ---
> mm/memcontrol.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)