Re: [PATCH] memcg: don't do cleanup manually if mem_cgroup_css_online() fails

Glauber Costa
2013-04-02T14:20:56Z

On 04/02/2013 06:16 PM, Michal Hocko wrote:
> mem_cgroup_css_online
> memcg_init_kmem
> mem_cgroup_get # refcnt = 2
> memcg_update_all_caches
> memcg_update_cache_size # fails with ENOMEM

Here is the thing: this one in kmem only happens for kmem enabled
memcgs. For those, we tend to do a get once, and put only when the last
kmem reference is gone.

For non-kmem memcgs, refcnt will be 1 here, and will be balanced out by
the mem_cgroup_put() in css_free.