Re: [PATCH] memcg: don't do cleanup manually if mem_cgroup_css_online() fails

Glauber Costa
2013-04-02T08:43:46Z

On 04/02/2013 11:35 AM, Li Zefan wrote:
> If memcg_init_kmem() returns -errno when a memcg is being created,
> mem_cgroup_css_online() will decrement memcg and its parent's refcnt,
> (but strangely there's no mem_cgroup_put() for mem_cgroup_get() called
> in memcg_propagate_kmem()).
>
> But then cgroup core will call mem_cgroup_css_free() to do cleanup...
>

Not a kmemcg bug, but a real bug. Tested by forcing an ENOMEM condition
to happen manually, and Li patch fixes it.
> Signed-off-by: Li Zefan <lizefan@huawei.com>

Acked-by: Glauber Costa <glommer@parallels.com>