From: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Rami Rosen <ramirose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cgroup: remove bind() method from cgroup_subsys.
Date: Thu, 11 Apr 2013 11:02:39 +0400 [thread overview]
Message-ID: <5166600F.3090303@parallels.com> (raw)
In-Reply-To: <CAOS58YP8V=GNrkRJN1G3EJrdVgK6NPcvm+30SW_xjC1Sq2QBng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 04/11/2013 06:06 AM, Tejun Heo wrote:
> Hello, Li.
>
> On Wed, Apr 10, 2013 at 7:02 PM, Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>> I remember Glauber once used the bind() callback to detect if cpuacct and
>> cpu are mounted together and if so do some optimization.
>>
>> Then he gave up on it and just deprecated cpuacct, but then it was decided
>> that it can't be decprecated and removed as that will break userspace.
>>
>> So mayber Glauber will want to use this callback again?
>
> There was a patchset which made cpu provide the same stats as cpuacct
> if mounted together, which bitrotted while Peter was away. We probably
> should resurrect those patches. I don't recall whether it used ->bind
> or not. Glauber?
>
The patch didn't suffer any change in its last 2 iteractions, so I was
just waiting for someone to apply =p (or well, say something)
It re-uses the infrastructure that you built in cgroup.c to detect
comounting, so it does not use bind.
I must add that I used bind just because "it was already there", and at
the time we were also quite concerned about not increasing even more the
number of callbacks. It is a horrible interface IMHO.
next prev parent reply other threads:[~2013-04-11 7:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 11:41 [PATCH] cgroup: remove bind() method from cgroup_subsys Rami Rosen
[not found] ` <1365594077-17655-1-git-send-email-ramirose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-10 17:50 ` Tejun Heo
[not found] ` <20130410175035.GA17641-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-04-11 2:02 ` Li Zefan
[not found] ` <5166199F.7090104-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-11 2:06 ` Tejun Heo
[not found] ` <CAOS58YP8V=GNrkRJN1G3EJrdVgK6NPcvm+30SW_xjC1Sq2QBng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-11 7:02 ` Glauber Costa [this message]
[not found] ` <5166600F.3090303-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-04-11 9:30 ` Li Zefan
2013-04-11 18:49 ` Tejun Heo
2013-04-12 17:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166600F.3090303@parallels.com \
--to=glommer-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=ramirose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox