From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [PATCH 4/4] memcg: force use_hierarchy if sane_behavior Date: Tue, 16 Apr 2013 00:29:14 +0900 Message-ID: <516C1CCA.80901@jp.fujitsu.com> References: <1365808259-31073-1-git-send-email-tj@kernel.org> <1365808259-31073-5-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1365808259-31073-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org (2013/04/13 8:10), Tejun Heo wrote: > Turn on use_hierarchy by default if sane_behavior is specified and > don't create .use_hierarchy file. > > It is debatable whether to remove .use_hierarchy file or make it ro as > the former could make transition easier in certain cases; however, the > behavior changes which will be gated by sane_behavior are intensive > including changing basic meaning of certain control knobs in a few > controllers and I don't really think keeping this piece would make > things easier in any noticeable way, so let's remove it. > > Signed-off-by: Tejun Heo > Cc: Michal Hocko > Cc: KAMEZAWA Hiroyuki I'd like to say this behaivor as v2 rather than sane_behavior.... Acked-by: KAMEZAWA Hiroyuki Hmm.. we need to check performance.