* [PATCH] cpuset: fix compile warning when CONFIG_SMP=n
@ 2013-04-28 1:46 Li Zefan
2013-04-28 2:01 ` Li Zhong
[not found] ` <517C7F91.2030705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Li Zefan @ 2013-04-28 1:46 UTC (permalink / raw)
To: Tejun Heo; +Cc: LKML, Cgroups, Li Zhong, Fengguang Wu
Reported by Fengguang's kbuild test robot:
kernel/cpuset.c:787: warning: 'generate_sched_domains' defined but not used
Introduced by commit e0e80a02e5701c8790bd348ab59edb154fbda60b
("cpuset: use rebuild_sched_domains() in cpuset_hotplug_workfn()),
which removed generate_sched_domains() from cpuset_hotplug_workfn().
Reported-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
kernel/cpuset.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index ef05901..2422c5b 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -789,13 +789,6 @@ out:
static void rebuild_sched_domains_locked(void)
{
}
-
-static int generate_sched_domains(cpumask_var_t **domains,
- struct sched_domain_attr **attributes)
-{
- *domains = NULL;
- return 1;
-}
#endif /* CONFIG_SMP */
void rebuild_sched_domains(void)
--
1.8.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cpuset: fix compile warning when CONFIG_SMP=n
2013-04-28 1:46 [PATCH] cpuset: fix compile warning when CONFIG_SMP=n Li Zefan
@ 2013-04-28 2:01 ` Li Zhong
[not found] ` <517C7F91.2030705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Li Zhong @ 2013-04-28 2:01 UTC (permalink / raw)
To: Li Zefan; +Cc: Tejun Heo, LKML, Cgroups, Fengguang Wu
On Sun, 2013-04-28 at 09:46 +0800, Li Zefan wrote:
> Reported by Fengguang's kbuild test robot:
Thank you for the quick fix, Zefan.
Strong robot :)
Thanks, Zhong
>
> kernel/cpuset.c:787: warning: 'generate_sched_domains' defined but not used
>
> Introduced by commit e0e80a02e5701c8790bd348ab59edb154fbda60b
> ("cpuset: use rebuild_sched_domains() in cpuset_hotplug_workfn()),
> which removed generate_sched_domains() from cpuset_hotplug_workfn().
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
> ---
> kernel/cpuset.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
> index ef05901..2422c5b 100644
> --- a/kernel/cpuset.c
> +++ b/kernel/cpuset.c
> @@ -789,13 +789,6 @@ out:
> static void rebuild_sched_domains_locked(void)
> {
> }
> -
> -static int generate_sched_domains(cpumask_var_t **domains,
> - struct sched_domain_attr **attributes)
> -{
> - *domains = NULL;
> - return 1;
> -}
> #endif /* CONFIG_SMP */
>
> void rebuild_sched_domains(void)
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <517C7F91.2030705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] cpuset: fix compile warning when CONFIG_SMP=n
[not found] ` <517C7F91.2030705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2013-04-28 2:55 ` Tejun Heo
0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2013-04-28 2:55 UTC (permalink / raw)
To: Li Zefan; +Cc: LKML, Cgroups, Li Zhong, Fengguang Wu
On Sun, Apr 28, 2013 at 09:46:57AM +0800, Li Zefan wrote:
> Reported by Fengguang's kbuild test robot:
>
> kernel/cpuset.c:787: warning: 'generate_sched_domains' defined but not used
>
> Introduced by commit e0e80a02e5701c8790bd348ab59edb154fbda60b
> ("cpuset: use rebuild_sched_domains() in cpuset_hotplug_workfn()),
> which removed generate_sched_domains() from cpuset_hotplug_workfn().
>
> Reported-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Applied to cgroup/for-3.10. Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-28 2:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-28 1:46 [PATCH] cpuset: fix compile warning when CONFIG_SMP=n Li Zefan
2013-04-28 2:01 ` Li Zhong
[not found] ` <517C7F91.2030705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-04-28 2:55 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox