From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid' Date: Wed, 8 May 2013 08:50:46 +0800 Message-ID: <5189A166.9080301@huawei.com> References: <5188DB93.2080504@asianux.com> <5188DF27.4080000@huawei.com> <5188E391.6040505@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5188E391.6040505-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Chen Gang Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" >> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after >> ss->css_free(). That said, given there's no modular cgroup subsystem using css_id, >> and the whole css_id thing will be eliminated in 3.11, why bother fixing it. >> > > I just find it by reading code (I also want to learn about kernel). > > I guess, for some stable versions, may focus on it, they are the > different branches from the latest version. > > So, is it suitable to send related patch for the bug ? > As I said, there's no modular cgroup subsystem using css_id, so the bug doesn't exist in real world.