Re: [PATCH 1/4] memcg: correct RESOURCE_MAX to ULLONG_MAX

Michal Hocko
2013-07-31T08:00:12Z

On Wed 31-07-13 15:31:22, Qiang Huang wrote:
> Current RESOURCE_MAX is ULONG_MAX, but the value we used to set resource
> limit is unsigned long long, so we can set bigger value than that which
> is strange. The XXX_MAX should be reasonable max value, bigger than that
> should be overflow.
>
> Notice that this change will affect user output of default *.limit_in_bytes:
> before change:
> $ cat /cgroup/memory/memory.limit_in_bytes
> 9223372036854775807
>
> after change:
> $ cat /cgroup/memory/memory.limit_in_bytes
> 18446744073709551615
>
> But it doesn't alter the API in term of input - we can still use
> "echo -1 > *.limit_in_bytes" to reset the numbers to "unlimited".
>
> Signed-off-by: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Qiang Huang <h.huangqiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

I thought this would be better marked as cgroup wide change but memcg
seems to be the only user currently

Acked-by: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>

> ---
> include/linux/res_counter.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h
> index 96a509b..586bc7c 100644
> --- a/include/linux/res_counter.h
> +++ b/include/linux/res_counter.h
> @@ -54,7 +54,7 @@ struct res_counter {
> struct res_counter *parent;
> };
>
> -#define RESOURCE_MAX (unsigned long long)LLONG_MAX
> +#define RESOURCE_MAX ULLONG_MAX
>
> /**
> * Helpers to interact with userspace
> --
> 1.8.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Michal Hocko
SUSE Labs