Re: [PATCH 0/4] memcg: fix memcg resource limit overflow issues

Qiang Huang
2013-07-31T09:51:01Z

On 2013/7/31 17:39, Sha Zhengju wrote:
> On Wed, Jul 31, 2013 at 4:54 PM, Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>> On 2013/7/31 16:51, Qiang Huang wrote:
>>> On 2013/7/31 16:23, Sha Zhengju wrote:
>>>> Hi list,
>>>>
>>>> On Wed, Jul 31, 2013 at 3:31 PM, Qiang Huang <h.huangqiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>>>>> This issue is first discussed in:
>>>>> http://marc.info/?l=linux-mm&m=136574878704295&w=2
>>>>>
>>>>> Then a second version sent to:
>>>>> http://marc.info/?l=linux-mm&m=136776855928310&w=2
>>>>>
>>>>> We contacted Sha a month ago, she seems have no time to deal with it
>>>>> recently, but we quite need this patch. So I modified and resent it.
>>>>
>>>>
>>>> No, I didn't receive any of YOUR message, only a engineer named Libo
>>>> Chen from Huawei connected me recently. I don't approve you to resent
>>>> them on behalf of me, and just before you send this you even don't
>>>> send me a mail. Besides, after a rough look, I do not see any
>>>> innovative ideas from yourself but just rework patches from my last
>>>> version.
>>>> So I'm strong against this patchset.
>>>
>>> Sorry if this troubles you.
>>> Libo Chen is my colleague, we work together, he sent an email to you on
>>> 25 June, to ask about this issue, you said you'll resent it soon, but it
>>> didn't happen until now :(, and he asked again the other day and you didn't
>>> reply. As we really need to fix this problem(and need it in upstream), so
>>> I modified it and sent out.
>>>
>>> I think split patches, rewrite changelogs and tests, they all kind of work
>>> right? Of course, if you mind, I can change it, I just need this fix merged
>>> to upstream ASAP.
>>>
>>> So you want me rewrite this patchset and SOB only you or you want resent this
>>> by yourself? I'm ok with both :)
>>>
>>
>> No, you can't send out patches without your SOB...but you can add a line
>> in the beginning of the email:
>>
>> From: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
>>
>
> Cooperation is welcomed and I just hated this kind of behavior. I
> don't want to block the community, since they're urgent to the patches
> and Michal has already reviewed them just now, I won't be so caustic
> on it. I'm OK of letting the codes in under the rules of community.
>

OK, thank you Sha, I just confirmed again, Libo did get your reply, we
made a mistake, sorry for that.

It is my fault didn't get your permission before the rework, I didn't notice
this is that big deal, I'll be more careful next time :). Thanks again.