public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path
Date: Fri, 6 Dec 2013 22:02:30 +0400	[thread overview]
Message-ID: <52A21136.9090605@parallels.com> (raw)
In-Reply-To: <20131206161312.GC13373-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>

On 12/06/2013 08:13 PM, Tejun Heo wrote:
> Hello, Vladimir.
>
> On Fri, Dec 06, 2013 at 11:02:07AM +0400, Vladimir Davydov wrote:
>> This patch fixes this bug, but I have a couple of questions regarding it.
>>
>> First, cgroup_load_subsys() also calls css_online(), and if it fails, it
>> calls cgroup_unload_subsys() to rollback. The latter function executes
>> the following command:
>>
>>     offline_css(cgroup_css(cgroup_dummy_top, ss));
>>
>> But since we failed to online_css(), cgroup_css() will return NULL
>> resulting in another oops.
> I don't think the root css onlining fails for any existing controllers
> but yeah that looks wrong.  Can you please send a patch?

Sure, I will send it soon.

Thanks.

  parent reply	other threads:[~2013-12-06 18:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05  9:00 [PATCH] cgroup: fix bug on cgroup_create() fail path Vladimir Davydov
2013-12-05 21:18 ` [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path Tejun Heo
     [not found]   ` <20131205211814.GA29598-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-12-06  7:02     ` Vladimir Davydov
     [not found]       ` <52A1766F.5090808-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-12-06 16:13         ` Tejun Heo
     [not found]           ` <20131206161312.GC13373-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-12-06 16:25             ` Tejun Heo
     [not found]               ` <20131206162503.GD13373-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-12-06 18:04                 ` Vladimir Davydov
2013-12-06 18:02             ` Vladimir Davydov [this message]
2013-12-09  9:10     ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A21136.9090605@parallels.com \
    --to=vdavydov-bzqdu9zft3wakbo8gow8eq@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox