From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [PATCH v13 13/16] vmscan: take at least one pass with shrinkers Date: Tue, 10 Dec 2013 15:50:08 +0400 Message-ID: <52A6FFF0.6080207@parallels.com> References: <5287164773f8aade33ce17f3c91546c6e1afaf85.1386571280.git.vdavydov@parallels.com> <20131210041826.GB31386@dastard> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131210041826.GB31386@dastard> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Dave Chinner Cc: dchinner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, glommer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Glauber Costa , Mel Gorman , Rik van Riel On 12/10/2013 08:18 AM, Dave Chinner wrote: > On Mon, Dec 09, 2013 at 12:05:54PM +0400, Vladimir Davydov wrote: >> From: Glauber Costa >> >> In very low free kernel memory situations, it may be the case that we >> have less objects to free than our initial batch size. If this is the >> case, it is better to shrink those, and open space for the new workload >> then to keep them and fail the new allocations. >> >> In particular, we are concerned with the direct reclaim case for memcg. >> Although this same technique can be applied to other situations just as >> well, we will start conservative and apply it for that case, which is >> the one that matters the most. > This should be at the start of the series. Since Glauber wanted to introduce this only for memcg-reclaim first, this can't be at the start of the series, but I'll move it to go immediately after per-memcg shrinking core in the next iteration. Thanks.