* [PATCH] arm, pm, vmpressure: add missing slab.h includes
@ 2014-01-28 22:19 Tejun Heo
[not found] ` <20140128221922.GC16060-9pTldWuhBndy/B6EtB590w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2014-01-28 22:19 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Rafael J. Wysocki,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Johannes Weiner, Michal Hocko,
Balbir Singh, KAMEZAWA Hiroyuki, cgroups-u79uwXL29TY76Z2rM5mHXA
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA
arch/arm/mach-tegra/pm.c, kernel/power/console.c and mm/vmpressure.c
were somehow getting slab.h indirectly through cgroup.h which in turn
was getting it indirectly through xattr.h. A scheduled cgroup change
drops xattr.h inclusion from cgroup.h and breaks compilation of these
three files. Add explicit slab.h includes to the three files.
A pending cgroup patch depends on this change and it'd be great if
this can be routed through cgroup/for-3.14-fixes branch.
Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: Balbir Singh <bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
If you guys are okay with this going through cgroup/for-3.14-fixes,
can you please ack it?
Thanks!
arch/arm/mach-tegra/pm.c | 1 +
kernel/power/console.c | 1 +
mm/vmpressure.c | 1 +
3 files changed, 3 insertions(+)
--- a/arch/arm/mach-tegra/pm.c
+++ b/arch/arm/mach-tegra/pm.c
@@ -24,6 +24,7 @@
#include <linux/cpu_pm.h>
#include <linux/suspend.h>
#include <linux/err.h>
+#include <linux/slab.h>
#include <linux/clk/tegra.h>
#include <asm/smp_plat.h>
--- a/kernel/power/console.c
+++ b/kernel/power/console.c
@@ -9,6 +9,7 @@
#include <linux/kbd_kern.h>
#include <linux/vt.h>
#include <linux/module.h>
+#include <linux/slab.h>
#include "power.h"
#define SUSPEND_CONSOLE (MAX_NR_CONSOLES-1)
--- a/mm/vmpressure.c
+++ b/mm/vmpressure.c
@@ -19,6 +19,7 @@
#include <linux/mm.h>
#include <linux/vmstat.h>
#include <linux/eventfd.h>
+#include <linux/slab.h>
#include <linux/swap.h>
#include <linux/printk.h>
#include <linux/vmpressure.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm, pm, vmpressure: add missing slab.h includes
[not found] ` <20140128221922.GC16060-9pTldWuhBndy/B6EtB590w@public.gmane.org>
@ 2014-01-28 23:04 ` Stephen Warren
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2014-01-28 23:04 UTC (permalink / raw)
To: Tejun Heo, Thierry Reding, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
Rafael J. Wysocki, linux-pm-u79uwXL29TY76Z2rM5mHXA,
Johannes Weiner, Michal Hocko, Balbir Singh, KAMEZAWA Hiroyuki,
cgroups-u79uwXL29TY76Z2rM5mHXA
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 01/28/2014 03:19 PM, Tejun Heo wrote:
> arch/arm/mach-tegra/pm.c, kernel/power/console.c and mm/vmpressure.c
> were somehow getting slab.h indirectly through cgroup.h which in turn
> was getting it indirectly through xattr.h. A scheduled cgroup change
> drops xattr.h inclusion from cgroup.h and breaks compilation of these
> three files. Add explicit slab.h includes to the three files.
>
> A pending cgroup patch depends on this change and it'd be great if
> this can be routed through cgroup/for-3.14-fixes branch.
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-28 23:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-28 22:19 [PATCH] arm, pm, vmpressure: add missing slab.h includes Tejun Heo
[not found] ` <20140128221922.GC16060-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-01-28 23:04 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).