From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH] cgroup: explicitly init the early_init field Date: Tue, 22 Apr 2014 14:22:18 +0800 Message-ID: <53560A9A.4020800@huawei.com> References: <1398144449-9325-1-git-send-email-nasa4836@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398144449-9325-1-git-send-email-nasa4836-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jianyu Zhan Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 2014/4/22 13:27, Jianyu Zhan wrote: > For a cgroup subsystem who should init early, then it should carefully > take care of the implementation of css_alloc, because it will be called > before mm_init() setup the world. > > Luckily we don't, and we better explicitly assign the early_init field > to 0, for document reason. > If you think this is the right thing to do, you can apply the same reason to the initialization of other structures in the whole kernel tree. > Signed-off-by: Jianyu Zhan nack > --- > kernel/cgroup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 559f822..f23cb67 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -5325,5 +5325,6 @@ struct cgroup_subsys debug_cgrp_subsys = { > .css_alloc = debug_css_alloc, > .css_free = debug_css_free, > .base_cftypes = debug_files, > + .early_init = 0, > }; > #endif /* CONFIG_CGROUP_DEBUG */ >