From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marian Marinov Subject: Re: Protection against container fork bombs [WAS: Re: memcg with kmem limit doesn't recover after disk i/o causes limit to be hit] Date: Tue, 06 May 2014 14:40:55 +0300 Message-ID: <5368CA47.7030007@yuhu.biz> References: <20140416154650.GA3034@alpha.arachsys.com> <20140418155939.GE4523@dhcp22.suse.cz> <5351679F.5040908@parallels.com> <20140420142830.GC22077@alpha.arachsys.com> <20140422143943.20609800@oracle.com> <20140422200531.GA19334@alpha.arachsys.com> <535758A0.5000500@yuhu.biz> <20140423084942.560ae837@oracle.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yuhu.biz; s=default; t=1399376460; bh=FKgx8xpIwQmHz+jYLTNdYWVSPg6wMi6C0QPfrLlNWC4=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=bzTrTxPG9P35/M9G9lvRYwEqJG2Kod84y0FJcvckwHomSt2fGITKXdc8BSIfbPUnd 3BM7EsWKKCuBN65B1opIjp93M+I2bfyGbG7Em4SixjZzdXTPX3G3dmtJO6fy3O8D/Q MHqSUEHHQFp98fVYx4vu5zxo1by2wmI3i9Isw/Yg= In-Reply-To: <20140423084942.560ae837@oracle.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Dwight Engen Cc: Richard Davies , Vladimir Davydov , Frederic Weisbecker , David Rientjes , Glauber Costa , Tejun Heo , Max Kellermann , Johannes Weiner , William Dauchy , Tim Hockin , Michal Hocko , Daniel Walsh , Daniel Berrange , cgroups@vger.kernel.org, containers@lists.linux-foundation.org, linux-mm@kvack.org On 04/23/2014 03:49 PM, Dwight Engen wrote: > On Wed, 23 Apr 2014 09:07:28 +0300 > Marian Marinov wrote: > >> On 04/22/2014 11:05 PM, Richard Davies wrote: >>> Dwight Engen wrote: >>>> Richard Davies wrote: >>>>> Vladimir Davydov wrote: >>>>>> In short, kmem limiting for memory cgroups is currently broken. >>>>>> Do not use it. We are working on making it usable though. >>> ... >>>>> What is the best mechanism available today, until kmem limits >>>>> mature? >>>>> >>>>> RLIMIT_NPROC exists but is per-user, not per-container. >>>>> >>>>> Perhaps there is an up-to-date task counter patchset or similar? >>>> >>>> I updated Frederic's task counter patches and included Max >>>> Kellermann's fork limiter here: >>>> >>>> http://thread.gmane.org/gmane.linux.kernel.containers/27212 >>>> >>>> I can send you a more recent patchset (against 3.13.10) if you >>>> would find it useful. >>> >>> Yes please, I would be interested in that. Ideally even against >>> 3.14.1 if you have that too. >> >> Dwight, do you have these patches in any public repo? >> >> I would like to test them also. > > Hi Marian, I put the patches against 3.13.11 and 3.14.1 up at: > > git://github.com/dwengen/linux.git cpuacct-task-limit-3.13 > git://github.com/dwengen/linux.git cpuacct-task-limit-3.14 > Guys I tested the patches with 3.12.16. However I see a problem with them. Trying to set the limit to a cgroup which already have processes in it does not work: [root@sp2 lxc]# echo 50 > cpuacct.task_limit -bash: echo: write error: Device or resource busy [root@sp2 lxc]# echo 0 > cpuacct.task_limit -bash: echo: write error: Device or resource busy [root@sp2 lxc]# I have even tried to remove this check: + if (cgroup_task_count(cgrp) || !list_empty(&cgrp->children)) + return -EBUSY; But still give me 'Device or resource busy'. Any pointers of why is this happening ? Marian >> Marian >> >>> >>> Thanks, >>> >>> Richard. >>> -- >>> To unsubscribe from this list: send the line "unsubscribe cgroups" >>> in the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >>> >> > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org