cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH 2/3] cgroup: make the default root invisible when it's umounted
Date: Tue, 3 Jun 2014 12:05:22 +0800	[thread overview]
Message-ID: <538D4982.10905@huawei.com> (raw)
In-Reply-To: <538D4956.5050205@huawei.com>

Before this patch (in a fresh system):

   # cat /proc/$$/cgroup
   # mount -t cgroup -o __DEVEL__sane_behavior xxx /cgroup
   # umount /cgroup
   # cat /proc/$$/cgroup
   0:cpuset,cpu,cpuacct,memory,devices,freezer,net_cls,blkio,perf_event,net_prio,hugetlb:/

After this patch (in a fresh system):

   # cat ...
   # mount ...
   # umount ...
   # cat /proc/$$/cgroup
   #

You won't see the default root after it's umounted.

Signed-off-by: Li Zefan <lizefan@huawei.com>
---
 kernel/cgroup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index f73fe48..dabc486 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1788,6 +1788,8 @@ static void cgroup_kill_sb(struct super_block *sb)
 	} else {
 		if (root != &cgrp_dfl_root)
 			percpu_ref_kill(&root->cgrp.self.refcnt);
+		else
+			cgrp_dfl_root_visible = false;
 	}
 
 	kernfs_kill_sb(sb);
-- 
1.8.0.2

  reply	other threads:[~2014-06-03  4:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03  4:04 [PATCH 1/3] cgroup: don't destroy the default root Li Zefan
2014-06-03  4:05 ` Li Zefan [this message]
     [not found]   ` <538D4982.10905-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-03 13:01     ` [PATCH 2/3] cgroup: make the default root invisible when it's umounted Tejun Heo
     [not found]       ` <20140603130144.GB26210-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-06-04  8:59         ` Li Zefan
     [not found]           ` <538EE00F.10406-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-05  1:20             ` Tejun Heo
2014-06-05  1:49               ` Li Zefan
     [not found] ` <538D4956.5050205-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-03  4:05   ` [PATCH 3/3] cgroup: set visible flag only after we've mounted the default root Li Zefan
     [not found]     ` <538D49A7.2010403-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-03 13:02       ` Tejun Heo
2014-06-03 12:57   ` [PATCH 1/3] cgroup: don't destroy " Tejun Heo
     [not found]     ` <20140603125728.GA26210-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-06-04  8:40       ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538D4982.10905@huawei.com \
    --to=lizefan@huawei.com \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).