Re: [PATCH v2 RESEND] cfq-iosched: Fix wrong children_weight calculation

Toshiaki Makita
2014-08-28T02:20:54Z

(2014/08/27 23:15), Tejun Heo wrote:
> As it looks like the patch needs to be respun anyway.
>
> On Wed, Aug 27, 2014 at 05:32:32PM +0900, Toshiaki Makita wrote:
>> + /*
>> + * Update leaf_weight. We cannot update weight at this point
>> + * because cfqg might already have been activated by its child.
>
> Maybe something like the following is better?
>
> because cfqg might already have been activated and is contributing
> its current weight to the parent's child_weight.
>

Thank you for your comment.
It looks better.
I'll reword it.

Thanks,
Toshiaki Makita