Re: [PATCH v2 RESEND] cfq-iosched: Fix wrong children_weight calculation

Tejun Heo
2014-08-27T14:15:05Z

As it looks like the patch needs to be respun anyway.

On Wed, Aug 27, 2014 at 05:32:32PM +0900, Toshiaki Makita wrote:
> + /*
> + * Update leaf_weight. We cannot update weight at this point
> + * because cfqg might already have been activated by its child.

Maybe something like the following is better?

because cfqg might already have been activated and is contributing
its current weight to the parent's child_weight.

Thanks.

--
tejun