Re: [PATCH] cgroup: fix written mistake in warning message

[Xiubo Li <lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>]

On 26/02/2016 12:16, Zefan Li wrote:
> On 2016/2/26 10:42, Xiubo Li wrote:
>> There is written mistake about the print format name:id <--> %d:%s,
>> which the name is 'char *' type and id is 'int' type.
>>
>> Signed-off-by: Xiubo Li <lixiubo-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org>
>
> Good catch. :)
>
> but could instead change "name:id" to "id:name"? so it's consistent with
> "cgroup_subsys %d:%s".
>

Sure, Please see the next version.

Thanks,


>> ---
>>   kernel/cgroup.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
>> index cc40463..0f82d16 100644
>> --- a/kernel/cgroup.c
>> +++ b/kernel/cgroup.c
>> @@ -5324,9 +5324,9 @@ int __init cgroup_init_early(void)
>>
>>   	for_each_subsys(ss, i) {
>>   		WARN(!ss->css_alloc || !ss->css_free || ss->name || ss->id,
>> -		     "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%d:%s\n",
>> +		     "invalid cgroup_subsys %d:%s css_alloc=%p css_free=%p name:id=%s:%d\n",
>>   		     i, cgroup_subsys_name[i], ss->css_alloc, ss->css_free,
>> -		     ss->id, ss->name);
>> +		     ss->name, ss->id);
>>   		WARN(strlen(cgroup_subsys_name[i]) > MAX_CGROUP_TYPE_NAMELEN,
>>   		     "cgroup_subsys_name %s too long\n", cgroup_subsys_name[i]);
>>
>>
>