From: Damien Le Moal <dlemoal@kernel.org>
To: Yu Kuai <hailan@yukuai.org.cn>, Yu Kuai <yukuai1@huaweicloud.com>,
axboe@kernel.dk, tj@kernel.org, josef@toxicpanda.com,
song@kernel.org, neil@brown.name, akpm@linux-foundation.org,
hch@infradead.org, colyli@kernel.org, hare@suse.de,
tieren@fnnas.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-raid@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com
Subject: Re: [PATCH RFC v2 02/10] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset()
Date: Sat, 30 Aug 2025 13:38:43 +0900 [thread overview]
Message-ID: <67d5b14f-25e3-4180-8917-f950b766d4dc@kernel.org> (raw)
In-Reply-To: <e147e288-de38-4f2c-8068-53c5e37b2310@yukuai.org.cn>
On 8/30/25 13:10, Yu Kuai wrote:
> Hi,
>
> 在 2025/8/30 8:41, Damien Le Moal 写道:
>> On 8/28/25 15:57, Yu Kuai wrote:
>>> From: Yu Kuai <yukuai3@huawei.com>
>>>
>>> On the one hand unify bio split code, prepare to fix disordered split
>>> IO; On the other hand fix missing blkcg_bio_issue_init() and
>>> trace_block_split() for split IO.
>> Hmmm... Shouldn't that be a prep patch with a fixes tag for backport ?
>> Because that "fix" here is not done directly but is the result of calling
>> bio_submit_split_bioset().
>
> I can add a fix tag as blkcg_bio_issue_init() and trace_block_split() is missed,
> however, if we consider stable backport, should we fix this directly from caller
> first? As this is better for backport. Later this patch can be just considered
> cleanup.
That is what I was suggesting: fix the blkcg issue first withe fixes tag and
then do the conversion to using bio_submit_split_bioset() in later patch that is
not to be backported.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-08-30 4:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 6:57 [PATCH RFC v2 00/10] block: fix disordered IO in the case recursive split Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 01/10] block: factor out a helper bio_submit_split_bioset() Yu Kuai
2025-08-30 0:37 ` Damien Le Moal
2025-08-30 4:03 ` Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 02/10] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset() Yu Kuai
2025-08-30 0:41 ` Damien Le Moal
2025-08-30 4:10 ` Yu Kuai
2025-08-30 4:38 ` Damien Le Moal [this message]
2025-08-28 6:57 ` [PATCH RFC v2 03/10] md/raid1: convert " Yu Kuai
2025-08-30 0:43 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 04/10] md/raid10: convert read/write " Yu Kuai
2025-08-30 0:48 ` Damien Le Moal
2025-08-30 4:18 ` Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 05/10] md/raid5: convert " Yu Kuai
2025-08-30 0:50 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 06/10] md/md-linear: " Yu Kuai
2025-08-30 0:51 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 07/10] blk-crypto: " Yu Kuai
2025-08-30 0:55 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 08/10] block: skip unnecessary checks for split bio Yu Kuai
2025-08-30 0:58 ` Damien Le Moal
2025-08-30 4:22 ` Yu Kuai
2025-08-28 6:57 ` [PATCH RFC v2 09/10] block: fix disordered IO in the case recursive split Yu Kuai
2025-08-30 1:02 ` Damien Le Moal
2025-08-30 4:28 ` Yu Kuai
2025-09-01 2:40 ` Yu Kuai
2025-09-01 6:51 ` Damien Le Moal
2025-08-28 6:57 ` [PATCH RFC v2 10/10] md/raid0: convert raid0_make_request() to use bio_submit_split_bioset() Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d5b14f-25e3-4180-8917-f950b766d4dc@kernel.org \
--to=dlemoal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=colyli@kernel.org \
--cc=hailan@yukuai.org.cn \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=johnny.chenyi@huawei.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neil@brown.name \
--cc=song@kernel.org \
--cc=tieren@fnnas.com \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).