public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sebastian Andrzej Siewior
	<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: Re: [RFC PATCH 0/2] cpuset: Skip possible unwanted CPU-mask updates.
Date: Fri, 11 Nov 2022 11:37:03 -0500	[thread overview]
Message-ID: <6948de71-a3e3-b6c2-bc67-1bb39cbdff69@redhat.com> (raw)
In-Reply-To: <Y25rcHYzix+kAJF9-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>


On 11/11/22 10:34, Sebastian Andrzej Siewior wrote:
> On 2022-11-02 09:20:48 [-0400], Waiman Long wrote:
> Hi,
>
>> Yes, that is a known issue which is especially problematic when cgroup v2 is
>> used. That is why I have recently posted a set of patches to enable
>> persistent user requested affinity and they have been merged into tip:
>>
>> 851a723e45d1 sched: Always clear user_cpus_ptr in do_set_cpus_allowed()
>> da019032819a sched: Enforce user requested affinity
>> 8f9ea86fdf99 sched: Always preserve the user requested cpumask
>> 713a2e21a513 sched: Introduce affinity_context
>> 5584e8ac2c68 sched: Add __releases annotations to affine_move_task()
>> They should be able to address the problem that you list here. Please let me
>> know if there are still problem remaining.
> Thank you. This solves the most pressing issue. The CPU-mask is still
> reset upon activation of the cpuset controller.
> This is due to the set_cpus_allowed_ptr() in cpuset_attach().
>
> Is is possible to push these patches stable?

Actually, I prefer to not call set_cpus_allowed_ptr() if the cpumask of 
the old and new cpusets are the same. That will save some cpu cycles. 
Similarly for node_mask. If there is any changes in the cpumask, we have 
to call set_cpus_allowed_ptr(). I will work out a patch to that effect 
when I have spare cycle.

Thanks,
Longman


  parent reply	other threads:[~2022-11-11 16:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 10:55 [RFC PATCH 0/2] cpuset: Skip possible unwanted CPU-mask updates Sebastian Andrzej Siewior
     [not found] ` <20221102105530.1795429-1-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-11-02 10:55   ` [RFC PATCH 1/2] cpuset: Don't change the cpumask on attach if it is a subset Sebastian Andrzej Siewior
2022-11-02 10:55   ` [RFC PATCH 2/2] cpuset: Don't change the cpumask if the task changed it Sebastian Andrzej Siewior
2022-11-02 13:20   ` [RFC PATCH 0/2] cpuset: Skip possible unwanted CPU-mask updates Waiman Long
     [not found]     ` <d0b43b7d-54d3-00bd-abe0-78212ee9355a-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-11-11 15:34       ` Sebastian Andrzej Siewior
     [not found]         ` <Y25rcHYzix+kAJF9-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-11-11 16:37           ` Waiman Long [this message]
     [not found]             ` <6948de71-a3e3-b6c2-bc67-1bb39cbdff69-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-11-11 16:49               ` Sebastian Andrzej Siewior
     [not found]                 ` <Y259IcCb937bw3AZ-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-11-11 17:34                   ` Waiman Long
     [not found]                     ` <f28a00c4-534c-d74a-a14a-f85a1849566e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-11-11 17:44                       ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6948de71-a3e3-b6c2-bc67-1bb39cbdff69@redhat.com \
    --to=longman-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox