cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Roman Gushchin <guro@fb.com>, cgroups@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan@huawei.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	kernel-team@fb.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: add cgroup.stat interface with basic hierarchy stats
Date: Thu, 27 Jul 2017 13:38:55 -0400	[thread overview]
Message-ID: <6a72e074-e01f-b93f-2c03-2bd0366d005b@redhat.com> (raw)
In-Reply-To: <20170727161420.2552-1-guro@fb.com>

On 07/27/2017 12:14 PM, Roman Gushchin wrote:
> Add a cgroup.stat interface to the base cgroup control files
> with the following metrics:
>
> nr_descendants		total number of descendant cgroups
> nr_dying_descendants	total number of dying descendant cgroups
> max_descendant_depth	maximum descent depth below the current cgroup

Both nr_descendants and max_descendant_depth can be found easily from
userspace by scanning the cgroup directory. nr_dying_descendants is a
transient figure and it should be 0 most of the time. So I wonder how
useful it can be.

This new interface file will be more useful if it can reveal information
that cannot be easily obtained by looking from userspace alone.

Cheers,
Longman



  parent reply	other threads:[~2017-07-27 17:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 16:14 [PATCH] cgroup: add cgroup.stat interface with basic hierarchy stats Roman Gushchin
2017-07-27 16:22 ` Tejun Heo
2017-07-28 13:01   ` Roman Gushchin
2017-07-28 15:09     ` Tejun Heo
2017-07-27 17:38 ` Waiman Long [this message]
2017-07-27 17:46   ` Roman Gushchin
     [not found]     ` <20170727174613.GA6457-B3w7+ongkCiLfgCeKHXN1g2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-07-27 17:55       ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a72e074-e01f-b93f-2c03-2bd0366d005b@redhat.com \
    --to=longman@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).