From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Ryabinin Subject: Re: [PATCH v3 2/2] mm/memcg: Consolidate mem_cgroup_resize_[memsw]_limit() functions. Date: Tue, 9 Jan 2018 20:26:33 +0300 Message-ID: <6ba40354-10d8-7955-7932-9dcd05ed5977@virtuozzo.com> References: <20171220135329.GS4831@dhcp22.suse.cz> <20180109165815.8329-1-aryabinin@virtuozzo.com> <20180109165815.8329-2-aryabinin@virtuozzo.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aGZJRSAL8eQ6SWPzRwtRfJhcGFA7GxGs/DRGP3MN/tA=; b=gi/n6S7mAqkxtvKBJluRLp1MsxYgyWsKPXogcNLkBzbgu0pV5J2gAw+T7RMtuCqm6gklnMjYPgEzJ2nAVQED2rouOmifz32qXkuZpyhAsh1tpNl69yKFl6sE0WRhrwDdufSgxaH1Oid2nFAL5YRmuaB01HtVDSkaX+Br6qTsvTo= In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , Cgroups , Linux MM , LKML , Michal Hocko On 01/09/2018 08:10 PM, Shakeel Butt wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Andrey Ryabinin wrote: >> mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() are almost >> identical functions. Instead of having two of them, we could pass an >> additional argument to mem_cgroup_resize_limit() and by using it, >> consolidate all the code in a single function. >> >> Signed-off-by: Andrey Ryabinin > > I think this is already proposed and Acked. > > https://patchwork.kernel.org/patch/10150719/ > Indeed. I'll rebase 1/2 patch on top, if it will be applied first.