public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linux.alibaba.com>
To: Hugh Dickins <hughd@google.com>, Vlastimil Babka <vbabka@suse.cz>
Cc: akpm@linux-foundation.org, mgorman@techsingularity.net,
	tj@kernel.org, khlebnikov@yandex-team.ru,
	daniel.m.jordan@oracle.com, willy@infradead.org,
	hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	shakeelb@google.com, iamjoonsoo.kim@lge.com,
	richard.weiyang@gmail.com, kirill@shutemov.name,
	alexander.duyck@gmail.com, rong.a.chen@intel.com,
	mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com
Subject: Re: [PATCH v21 15/19] mm/compaction: do page isolation first in compaction
Date: Thu, 12 Nov 2020 11:35:23 +0800	[thread overview]
Message-ID: <6d2d215e-fd72-b8cc-331f-189ea04a361d@linux.alibaba.com> (raw)
In-Reply-To: <alpine.LSU.2.11.2011111803580.2174@eggly.anvils>



ÔÚ 2020/11/12 ÉÏÎç10:28, Hugh Dickins дµÀ:
>>>   			 * Page become compound since the non-locked check,
>>>   			 * and it's on LRU. It can only be a THP so the order
>>> @@ -990,16 +1002,13 @@ static bool too_many_isolated(pg_data_t *pgdat)
> Completely off-topic, and won't matter at all when Andrew rediffs into
> mmotm: but isn't it weird that this is showing "too_many_isolated(",
> when actually the function is isolate_migratepages_block()?
> 

My git version is too low for this. Thanks for reminder. the latest git
work fine on correct function name.

Thanks

  reply	other threads:[~2020-11-12  3:35 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05  8:55 [PATCH v21 00/19] per memcg lru lock Alex Shi
2020-11-05  8:55 ` [PATCH v21 02/19] mm/thp: use head for head page in lru_add_page_tail Alex Shi
2020-11-05  8:55 ` [PATCH v21 03/19] mm/thp: Simplify lru_add_page_tail() Alex Shi
2020-11-05  8:55 ` [PATCH v21 04/19] mm/thp: narrow lru locking Alex Shi
     [not found] ` <1604566549-62481-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-05  8:55   ` [PATCH v21 01/19] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi
2020-11-05  8:55   ` [PATCH v21 05/19] mm/vmscan: remove unnecessary lruvec adding Alex Shi
     [not found]     ` <1604566549-62481-6-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-11 12:36       ` Vlastimil Babka
2020-11-05  8:55   ` [PATCH v21 07/19] mm: page_idle_get_page() does not need lru_lock Alex Shi
2020-11-10 19:01     ` Johannes Weiner
     [not found]     ` <1604566549-62481-8-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-11  8:17       ` huang ying
     [not found]         ` <CAC=cRTPYgD4qi=-dj=PY4804Y96k7fU065vLA8mNBmucZTnFSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-11-11 12:52           ` Vlastimil Babka
2020-11-05  8:55   ` [PATCH v21 08/19] mm/memcg: add debug checking in lock_page_memcg Alex Shi
2020-11-05  8:55   ` [PATCH v21 11/19] mm/vmscan: remove lruvec reget in move_pages_to_lru Alex Shi
2020-11-05  8:55   ` [PATCH v21 14/19] mm/lru: introduce TestClearPageLRU Alex Shi
2020-11-11 13:36     ` Vlastimil Babka
2020-11-12  2:03       ` Hugh Dickins
2020-11-12 11:24         ` Vlastimil Babka
2020-11-05  8:55   ` [PATCH v21 15/19] mm/compaction: do page isolation first in compaction Alex Shi
     [not found]     ` <1604566549-62481-16-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-11 17:12       ` Vlastimil Babka
2020-11-12  2:28         ` Hugh Dickins
2020-11-12  3:35           ` Alex Shi [this message]
     [not found]           ` <alpine.LSU.2.11.2011111803580.2174-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-11-12 11:25             ` Vlastimil Babka
2020-11-05  8:55   ` [PATCH v21 17/19] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi
     [not found]     ` <1604566549-62481-18-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-05 13:43       ` Alex Shi
     [not found]         ` <5b085715-292a-4b43-50b3-d73dc90d1de5-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-06  7:48           ` Alex Shi
     [not found]             ` <5a4c2b72-7ee8-2478-fc0e-85eb83aafec4-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-10 18:54               ` Johannes Weiner
2020-11-11 17:46       ` Vlastimil Babka
2020-11-11 17:59         ` Vlastimil Babka
2020-11-12 12:19       ` Vlastimil Babka
     [not found]         ` <f9cfab13-fae2-c384-90b2-9e3107273734-AlSwsSmVLrQ@public.gmane.org>
2020-11-12 14:19           ` Alex Shi
2020-11-05  8:55   ` [PATCH v21 18/19] mm/lru: introduce the relock_page_lruvec function Alex Shi
2020-11-06  7:50     ` Alex Shi
     [not found]       ` <66d8e79d-7ec6-bfbc-1c82-bf32db3ae5b7-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-10 18:59         ` Johannes Weiner
     [not found]     ` <1604566549-62481-19-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-12 12:31       ` Vlastimil Babka
2020-11-10 12:14   ` [PATCH v21 00/19] per memcg lru lock Alex Shi
2020-11-16  3:45   ` Alex Shi
2020-12-15  0:47   ` Andrew Morton
     [not found]     ` <20201214164712.39da20f908c6199eb4cde961-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2020-12-15  2:16       ` Hugh Dickins
     [not found]         ` <alpine.LSU.2.11.2012141734060.3082-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-12-15  2:28           ` Andrew Morton
2021-01-05 19:30   ` Qian Cai
     [not found]     ` <aebcdd933df3abad378aeafc1a07dfe9bbb25548.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-01-05 19:42       ` Shakeel Butt
     [not found]         ` <CALvZod448Ebw7YE-HVCNXNSbtvTcTvQx+_EqcyxTVd_SZ4ATBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-01-05 20:11           ` Qian Cai
     [not found]             ` <49be27f2652d4658f80c95bea171142c35513761.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-01-05 21:35               ` Hugh Dickins
     [not found]                 ` <alpine.LSU.2.11.2101051326410.6519-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2021-01-05 22:01                   ` Qian Cai
     [not found]                     ` <f127c35a34a391d20b05c53c17adeb72464b28ee.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2021-01-06  3:10                       ` Hugh Dickins
2020-11-05  8:55 ` [PATCH v21 06/19] mm/rmap: stop store reordering issue on page->mapping Alex Shi
     [not found]   ` <1604566549-62481-7-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-06  1:20     ` Alex Shi
2020-11-10 19:06       ` Johannes Weiner
2020-11-11  7:41       ` Hugh Dickins
2020-11-05  8:55 ` [PATCH v21 09/19] mm/swap.c: fold vm event PGROTATED into pagevec_move_tail_fn Alex Shi
2020-11-05  8:55 ` [PATCH v21 10/19] mm/lru: move lock into lru_note_cost Alex Shi
2020-11-05  8:55 ` [PATCH v21 12/19] mm/mlock: remove lru_lock on TestClearPageMlocked Alex Shi
     [not found]   ` <1604566549-62481-13-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-11 13:03     ` Vlastimil Babka
2020-11-05  8:55 ` [PATCH v21 13/19] mm/mlock: remove __munlock_isolate_lru_page Alex Shi
2020-11-11 13:07   ` Vlastimil Babka
2020-11-05  8:55 ` [PATCH v21 16/19] mm/swap.c: serialize memcg changes in pagevec_lru_move_fn Alex Shi
     [not found]   ` <1604566549-62481-17-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-11 18:00     ` Vlastimil Babka
2020-11-05  8:55 ` [PATCH v21 19/19] mm/lru: revise the comments of lru_lock Alex Shi
     [not found]   ` <1604566549-62481-20-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-11-12 12:37     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d2d215e-fd72-b8cc-331f-189ea04a361d@linux.alibaba.com \
    --to=alex.shi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.duyck@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=daniel.m.jordan@oracle.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=richard.weiyang@gmail.com \
    --cc=rong.a.chen@intel.com \
    --cc=shakeelb@google.com \
    --cc=shy828301@gmail.com \
    --cc=tj@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=vdavydov.dev@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox