From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Josef Bacik" <josef@toxicpanda.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Michal Koutný" <mkoutny@suse.com>,
"Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
Subject: Re: [PATCH-block v3 2/2] blk-cgroup: Flush stats at blkgs destruction path
Date: Tue, 13 Dec 2022 20:58:53 -0500 [thread overview]
Message-ID: <72fa1665-966a-76e6-be0c-e7fb288b1610@redhat.com> (raw)
In-Reply-To: <Y5jS825K7ej0jEV+@slm.duckdns.org>
On 12/13/22 14:30, Tejun Heo wrote:
> On Tue, Dec 13, 2022 at 01:44:46PM -0500, Waiman Long wrote:
>> + /*
>> + * Flush all the non-empty percpu lockless lists so as to release
>> + * the blkg references held by those lists which, in turn, may
>> + * allow the blkgs to be freed and release their references to
>> + * blkcg speeding up its freeing.
>> + */
> Can you mention the possible deadlock explicitly? This sounds more like an
> optimization.
I am mostly thinking about the optimization aspect. Yes, deadlock in the
sense that both blkgs and blkcg remained offline but not freed is
possible because of the references hold in those lockless list. It is a
problem if blkcg is the only controller in a cgroup. For cgroup that has
both the blkcg and memory controllers, it shouldn't be a problem as the
cgroup_rstat_flush() call in the release of memory cgroup will clear up
blkcg too. Right, I will update the comment to mention that.
Cheers,
Longman
prev parent reply other threads:[~2022-12-14 1:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 18:44 [PATCH-block v3 0/2] blk-cgroup: Fix potential UAF & flush rstat at blkgs destruction path Waiman Long
2022-12-13 18:44 ` [PATCH-block v3 1/2] bdi, blk-cgroup: Fix potential UAF of blkcg Waiman Long
[not found] ` <20221213184446.50181-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-12-13 19:29 ` Tejun Heo
[not found] ` <Y5jSllwwBdmQ1jQz-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-13 19:53 ` Waiman Long
[not found] ` <34a8c4a7-a58d-63fc-4599-accf1cbb6aae-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-12-14 16:54 ` Jens Axboe
[not found] ` <5fbaea42-14a7-27a8-cea1-3a59161ceba0-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2022-12-14 16:55 ` Waiman Long
[not found] ` <20221213184446.50181-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-12-13 18:44 ` [PATCH-block v3 2/2] blk-cgroup: Flush stats at blkgs destruction path Waiman Long
2022-12-13 19:30 ` Tejun Heo
2022-12-14 1:58 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72fa1665-966a-76e6-be0c-e7fb288b1610@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dennisszhou@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox