public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
To: Alexander Duyck
	<alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org,
	lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org,
	kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org,
	hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org,
	iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org
Subject: Re: [RFC PATCH 3/3] mm: Identify compound pages sooner in isolate_migratepages_block
Date: Fri, 14 Aug 2020 15:20:05 +0800	[thread overview]
Message-ID: <76f64f08-e2c7-9862-5e7f-6251032735f0@linux.alibaba.com> (raw)
In-Reply-To: <20200813040240.13054.76770.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

It has a slight performance drop too...

Thanks
Alex

在 2020/8/13 下午12:02, Alexander Duyck 写道:
> Signed-off-by: Alexander Duyck <alexander.h.duyck-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
>  mm/compaction.c |   33 ++++++++++++++++++---------------
>  1 file changed, 18 insertions(+), 15 deletions(-)

  parent reply	other threads:[~2020-08-14  7:20 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25 12:59 [PATCH v17 00/21] per memcg lru lock Alex Shi
2020-07-25 12:59 ` [PATCH v17 01/21] mm/vmscan: remove unnecessary lruvec adding Alex Shi
2020-08-06  3:47   ` Alex Shi
2020-07-25 12:59 ` [PATCH v17 02/21] mm/page_idle: no unlikely double check for idle page counting Alex Shi
2020-07-25 12:59 ` [PATCH v17 03/21] mm/compaction: correct the comments of compact_defer_shift Alex Shi
2020-07-27 17:29   ` Alexander Duyck
     [not found]     ` <CAKgT0UfmbdhpUdGy+4VircovmJfiJy9m-MN_o0LChNT_kWRUng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-28 11:59       ` Alex Shi
     [not found]         ` <3bd60e1b-a74e-050d-ade4-6e8f54e00b92-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-28 14:17           ` Alexander Duyck
2020-07-25 12:59 ` [PATCH v17 06/21] mm/thp: clean up lru_add_page_tail Alex Shi
2020-07-25 12:59 ` [PATCH v17 07/21] mm/thp: remove code path which never got into Alex Shi
2020-07-25 12:59 ` [PATCH v17 08/21] mm/thp: narrow lru locking Alex Shi
2020-07-25 12:59 ` [PATCH v17 10/21] mm/swap: fold vm event PGROTATED into pagevec_move_tail_fn Alex Shi
2020-07-25 12:59 ` [PATCH v17 11/21] mm/lru: move lru_lock holding in func lru_note_cost_page Alex Shi
     [not found]   ` <1595681998-19193-12-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-05 21:18     ` Alexander Duyck
2020-07-25 12:59 ` [PATCH v17 14/21] mm/compaction: do page isolation first in compaction Alex Shi
     [not found]   ` <1595681998-19193-15-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-04 21:35     ` Alexander Duyck
2020-08-06 18:38     ` Alexander Duyck
     [not found]       ` <CAKgT0UcbBv=QBK9ErqLKXoNLYxFz52L4fiiHy4h6zKdBs=YPOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-07  3:24         ` Alex Shi
     [not found]           ` <241ca157-104f-4f0d-7d5b-de394443788d-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-07 14:51             ` Alexander Duyck
     [not found]               ` <CAKgT0UdSrarC8j+G=LYRSadcaG6yNCoCfeVpFjEiHRJb4A77-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-10 13:10                 ` Alex Shi
     [not found]                   ` <8dbd004e-8eba-f1ec-a5eb-5dc551978936-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-10 14:41                     ` Alexander Duyck
2020-08-11  8:22                       ` Alex Shi
     [not found]                         ` <d9818e06-95f1-9f21-05c0-98f29ea96d89-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-11 14:47                           ` Alexander Duyck
2020-08-12 11:43                             ` Alex Shi
     [not found]                               ` <9581db48-cef3-788a-7f5a-8548fee56c13-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-12 12:16                                 ` Alex Shi
2020-08-12 16:51                                 ` Alexander Duyck
2020-08-13  1:46                                   ` Alex Shi
     [not found]                                     ` <3828d045-17e4-16aa-f0e6-d5dda7ad6b1b-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-13  2:17                                       ` Alexander Duyck
     [not found]                                         ` <CAKgT0Ud6ZQ4ZTm1cAUKCdb8FMu0fk9vXgf-bnmb0aY5ndDHwyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-13  3:52                                           ` Alex Shi
2020-08-13  4:02                                       ` [RFC PATCH 0/3] " Alexander Duyck
     [not found]                                         ` <20200813035100.13054.25671.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2020-08-13  4:02                                           ` [RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block Alexander Duyck
     [not found]                                             ` <20200813040224.13054.96724.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2020-08-13  6:56                                               ` Alex Shi
     [not found]                                                 ` <8ea9e186-b223-fb1b-5c82-2aa43c5e9f10-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-13 14:32                                                   ` Alexander Duyck
     [not found]                                                     ` <CAKgT0UcRFqXUOJ+QjgtjdQE6A7EMgAc_v9b7+mXy-ZJLvG2AgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-14  7:25                                                       ` Alex Shi
2020-08-13  7:44                                               ` Alex Shi
2020-08-13 14:26                                                 ` Alexander Duyck
2020-08-13  4:02                                           ` [RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip Alexander Duyck
     [not found]                                             ` <20200813040232.13054.82417.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2020-08-14  7:19                                               ` Alex Shi
     [not found]                                                 ` <6c072332-ff16-757d-99dd-b8fbae131a0c-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-14 14:24                                                   ` Alexander Duyck
     [not found]                                                     ` <CAKgT0Uf0TbRBVsuGZ1bgh5rdFp+vARkP=+GgD4-DP3Gy6cj+pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-14 21:15                                                       ` Alexander Duyck
     [not found]                                                         ` <650ab639-e66f-5ca6-a9a5-31e61c134ae7@linux.alibaba.com>
     [not found]                                                           ` <650ab639-e66f-5ca6-a9a5-31e61c134ae7-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-17 15:38                                                             ` Alexander Duyck
2020-08-18  6:50                                               ` Alex Shi
2020-08-13  4:02                                           ` [RFC PATCH 3/3] mm: Identify compound pages sooner in isolate_migratepages_block Alexander Duyck
     [not found]                                             ` <20200813040240.13054.76770.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2020-08-14  7:20                                               ` Alex Shi [this message]
2020-08-17 22:58     ` [PATCH v17 14/21] mm/compaction: do page isolation first in compaction Alexander Duyck
2020-07-25 12:59 ` [PATCH v17 16/21] mm/swap: serialize memcg changes in pagevec_lru_move_fn Alex Shi
2020-07-25 12:59 ` [PATCH v17 18/21] mm/lru: introduce the relock_page_lruvec function Alex Shi
     [not found]   ` <1595681998-19193-19-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-29 17:52     ` Alexander Duyck
     [not found]       ` <CAKgT0UdFDcz=CQ+6mzcjh-apwy3UyPqAuOozvYr+2PSCNQrENA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-30  6:08         ` Alex Shi
     [not found]           ` <3345bfbf-ebe9-b5e0-a731-77dd7d76b0c9-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-31 14:20             ` Alexander Duyck
2020-07-31 21:14     ` [PATCH RFC] mm: Add function for testing if the current lruvec lock is valid alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w
     [not found]       ` <159622999150.2576729.14455020813024958573.stgit-+uVpp3jiz/RcxmDmkzA3yGt3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
2020-07-31 23:54         ` Alex Shi
2020-08-02 18:20           ` Alexander Duyck
2020-08-04  6:13             ` Alex Shi
2020-07-25 12:59 ` [PATCH v17 19/21] mm/vmscan: use relock for move_pages_to_lru Alex Shi
2020-08-03 22:49   ` Alexander Duyck
     [not found]     ` <CAKgT0UebLfdju0Ny9ad5bigzAazqpzfwk2_JNQQ9yEHYyVm5-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-04  6:23       ` Alex Shi
2020-07-25 12:59 ` [PATCH v17 20/21] mm/pgdat: remove pgdat lru_lock Alex Shi
     [not found]   ` <1595681998-19193-21-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-03 22:42     ` Alexander Duyck
     [not found]       ` <CAKgT0UfZg5Wf2qNJ_=VPO1Cj8YuifZN8rG_X4Btq86ADmsVZFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-03 22:45         ` Alexander Duyck
     [not found]           ` <CAKgT0UciRJCPs_zrxri1pEJmJVKkHpEq=AFiVpJE99JJQe=Xrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-04  6:22             ` Alex Shi
2020-07-25 12:59 ` [PATCH v17 21/21] mm/lru: revise the comments of lru_lock Alex Shi
2020-08-03 22:37   ` Alexander Duyck
     [not found]     ` <CAKgT0UfpHjBTHvtZz7=WMhZZAunVYuNMpuYBQCiorERb5seFUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-04 10:04       ` Alex Shi
     [not found]         ` <f34e790f-50e6-112c-622f-d7ab804c6d22-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-04 14:29           ` Alexander Duyck
     [not found]             ` <CAKgT0UckqbmYJDE3L2Bg1Nr=Y=GT0OBx1GEhaZ14EbRTzd8tiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-06  1:39               ` Alex Shi
     [not found]                 ` <a1c6a3a6-f8e3-7bb5-e881-216a4b57ae84-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-06 16:27                   ` Alexander Duyck
     [not found] ` <1595681998-19193-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-25 12:59   ` [PATCH v17 04/21] mm/compaction: rename compact_deferred as compact_should_defer Alex Shi
2020-07-25 12:59   ` [PATCH v17 05/21] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi
2020-07-25 12:59   ` [PATCH v17 09/21] mm/memcg: add debug checking in lock_page_memcg Alex Shi
2020-07-25 12:59   ` [PATCH v17 12/21] mm/lru: move lock into lru_note_cost Alex Shi
2020-07-25 12:59   ` [PATCH v17 13/21] mm/lru: introduce TestClearPageLRU Alex Shi
     [not found]     ` <1595681998-19193-14-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-29  3:53       ` Alex Shi
2020-08-05 22:43         ` Alexander Duyck
     [not found]           ` <CAKgT0Ud1+FkJcTXR0MxZYFxd7mr=opdXfXKTqkmiu4NNMyT4bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-08-06  1:54             ` Alex Shi
2020-08-06 14:41               ` Alexander Duyck
2020-07-25 12:59   ` [PATCH v17 15/21] mm/thp: add tail pages into lru anyway in split_huge_page() Alex Shi
2020-07-25 12:59   ` [PATCH v17 17/21] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi
     [not found]     ` <1595681998-19193-18-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-27 23:34       ` Alexander Duyck
     [not found]         ` <CAKgT0UdaW4Rf43yULhQBuP07vQgmoPbaWHGKv1Z7fEPP6jH83w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-28  7:15           ` Alex Shi
2020-07-28 11:19           ` Alex Shi
     [not found]             ` <ccd01046-451c-463d-7c5d-9c32794f4b1e-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-28 14:54               ` Alexander Duyck
2020-07-29  1:00                 ` Alex Shi
     [not found]                   ` <09aeced7-cc36-0c9a-d40b-451db9dc54cc-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-29  1:27                     ` Alexander Duyck
     [not found]                       ` <CAKgT0UfCv9u3UaJnzh7CYu_nCggV8yesZNu4oxMGn4+mJYiFUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-29  2:27                         ` Alex Shi
2020-07-28 15:39           ` Alex Shi
     [not found]             ` <1fd45e69-3a50-aae8-bcc4-47d891a5e263-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-28 15:55               ` Alexander Duyck
2020-07-29  0:48                 ` Alex Shi
2020-08-06  7:41       ` Alex Shi
2020-07-29  3:54     ` Alex Shi
2020-07-27  5:40   ` [PATCH v17 00/21] per memcg lru lock Alex Shi
     [not found]     ` <49d4f3bf-ccce-3c97-3a4c-f5cefe2d623a-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-07-29 14:49       ` Alex Shi
2020-07-29 18:06         ` Hugh Dickins
2020-07-30  2:16           ` Alex Shi
     [not found]             ` <08c8797d-1935-7b41-b8db-d22f054912ac-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-03 15:07               ` Michal Hocko
     [not found]                 ` <20200803150704.GV5174-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-04  6:14                   ` Alex Shi
2020-07-31 21:31   ` Alexander Duyck
2020-08-04  8:36   ` Alex Shi
2020-08-04  8:36   ` Alex Shi
2020-08-04  8:37   ` Alex Shi
2020-08-04  8:37   ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76f64f08-e2c7-9862-5e7f-6251032735f0@linux.alibaba.com \
    --to=alex.shi-kpsofbns7gizrge5brqyagc/g2k4zdhf@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org \
    --cc=khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org \
    --cc=kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org \
    --cc=richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox