From: Jens Axboe <axboe@kernel.dk>
To: Yang Li <yang.lee@linux.alibaba.com>, tj@kernel.org
Cc: josef@toxicpanda.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] blk-cgroup: Fix some kernel-doc comments
Date: Thu, 1 Dec 2022 18:22:38 -0700 [thread overview]
Message-ID: <7aa9e496-747d-46ae-b250-d504d84af6e5@kernel.dk> (raw)
In-Reply-To: <20221202011713.14834-1-yang.lee@linux.alibaba.com>
On 12/1/22 6:17 PM, Yang Li wrote:
> Make the description of @gendisk to @disk in blkcg_schedule_throttle()
> to clear the below warnings:
>
> block/blk-cgroup.c:1850: warning: Function parameter or member 'disk' not described in 'blkcg_schedule_throttle'
> block/blk-cgroup.c:1850: warning: Excess function parameter 'gendisk' description in 'blkcg_schedule_throttle'
Please always include a fixes line:
Fixes: de185b56e8a6 ("blk-cgroup: pass a gendisk to blkcg_schedule_throttle")
--
Jens Axboe
next prev parent reply other threads:[~2022-12-02 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 1:17 [PATCH -next] blk-cgroup: Fix some kernel-doc comments Yang Li
2022-12-02 1:22 ` Jens Axboe [this message]
2022-12-02 1:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aa9e496-747d-46ae-b250-d504d84af6e5@kernel.dk \
--to=axboe@kernel.dk \
--cc=abaci@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox