Re: [PATH] cgroup: add cgroup_favordynmods= command-line option

[Waiman Long <longman@redhat.com>]

On 9/5/23 15:03, Waiman Long wrote:
>
> On 9/5/23 14:59, Waiman Long wrote:
>>
>> On 9/5/23 13:03, Luiz Capitulino wrote:
>>> On Thu, Aug 31, 2023 at 10:20:46AM -0400, Luiz Capitulino wrote:
>>>> We have a need of using favordynmods with cgroup v1, which doesn't 
>>>> support
>>>> changing mount flags during remount. Enabling CONFIG_FAVOR_DYNMODS at
>>>> build-time is not an option because we want to be able to selectively
>>>> enable it for certain systems.
>>>>
>>>> This commit addresses this by introducing the cgroup_favordynmods=
>>>> command-line option. This option works for both cgroup v1 and v2 and
>>>> also allows for disabling favorynmods when the kernel built with
>>>> CONFIG_FAVOR_DYNMODS=y.
>>>>
>>>> Signed-off-by: Luiz Capitulino <luizcap@amazon.com>
>>> Hi,
>>>
>>> Would somebody take a look at this patch please?
>>>
>>> Thanks,
>>>
>>> - Luiz
>>
>> The patch looks good to me. I do have a minor comment that it may be 
>> better to use the relatively new __ro_after_init qualifier instead of 
>> __read_mostly.
>>
> With this patch, CGROUP_FAVOR_DYNMODS kconfig option will have no 
> user. So this config option should be removed as well.

My bad. That is not true. Please ignore this comment.

Regards,
Longman