From: "taoyi.ty" <escape@linux.alibaba.com>
To: Tejun Heo <tj@kernel.org>
Cc: gregkh@linuxfoundation.org, lizefan.x@bytedance.com,
hannes@cmpxchg.org, mcgrof@kernel.org, keescook@chromium.org,
yzaikin@google.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
shanpeic@linux.alibaba.com
Subject: Re: [RFC PATCH 0/2] support cgroup pool in v1
Date: Fri, 10 Sep 2021 10:12:32 +0800 [thread overview]
Message-ID: <7b8d68c6-9a1c-dc19-e430-e044e4c4f210@linux.alibaba.com> (raw)
In-Reply-To: <YTjmP0EGEWGYhroM@slm.duckdns.org>
I am glad to receive your reply.
cgroup pool is a relatively simple solution that I think can
solve the problem.
I have tried making locking more granular, but in the end found
it too diffcult. cgroup_mutex protects almost all operation related
to cgroup. If not use cgroup_mutex, I have no idea how to design
lock mechanism to take both concurrent performance and
existing interfaces into account. Do you have any good advice?
thanks,
Yi Tao
On 2021/9/9 上午12:35, Tejun Heo wrote:
> Hello,
>
> On Wed, Sep 08, 2021 at 08:15:11PM +0800, Yi Tao wrote:
>> In order to solve this long-tail delay problem, we designed a cgroup
>> pool. The cgroup pool will create a certain number of cgroups in advance.
>> When a user creates a cgroup through the mkdir system call, a clean cgroup
>> can be quickly obtained from the pool. Cgroup pool draws on the idea of
>> cgroup rename. By creating pool and rename in advance, it reduces the
>> critical area of cgroup creation, and uses a spinlock different from
>> cgroup_mutex, which reduces scheduling overhead on the one hand, and eases
>> competition with attaching processes on the other hand.
> I'm not sure this is the right way to go about it. There are more
> conventional ways to improve scalability - making locking more granular and
> hunting down specific operations which take long time. I don't think cgroup
> management operations need the level of scalability which requires front
> caching.
>
> Thanks.
>
prev parent reply other threads:[~2021-09-10 2:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 12:15 [RFC PATCH 0/2] support cgroup pool in v1 Yi Tao
2021-09-08 12:15 ` [RFC PATCH 1/2] add pinned flags for kernfs node Yi Tao
[not found] ` <e753e449240bfc43fcb7aa26dca196e2f51e0836.1631102579.git.escape-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
[not found] ` <cover.1631102579.git.escape-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2021-09-08 12:15 ` [RFC PATCH 2/2] support cgroup pool in v1 Yi Tao
[not found] ` <03e2b37678c9b2aef4f5dee303b3fb87a565d56b.1631102579.git.escape-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2021-09-08 12:35 ` Greg KH
[not found] ` <084930d2-057a-04a7-76d1-b2a7bd37deb0@linux.alibaba.com>
2021-09-09 13:27 ` Greg KH
2021-09-10 2:20 ` taoyi.ty
[not found] ` <YTiuLES5qd086qRu-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2021-09-10 2:15 ` taoyi.ty
[not found] ` <a91912e2-606a-0868-7a0c-38dec5012b02-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2021-09-10 6:01 ` Greg KH
2021-09-08 12:35 ` [RFC PATCH 1/2] add pinned flags for kernfs node Greg KH
2021-09-10 2:14 ` taoyi.ty
[not found] ` <3d871bd0-dab5-c9ca-61b9-6aa137fa9fdf-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2021-09-10 6:00 ` Greg KH
2021-09-08 12:37 ` [RFC PATCH 0/2] support cgroup pool in v1 Greg KH
2021-09-10 2:11 ` taoyi.ty
[not found] ` <a0c67d71-8045-d8b6-40c2-39f2603ec7c1-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2021-09-10 6:01 ` Greg KH
2021-09-10 16:49 ` Tejun Heo
[not found] ` <YTuMl+cC6FyA/Hsv-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2021-09-13 14:20 ` Christian Brauner
2021-09-13 16:24 ` Tejun Heo
2021-09-08 16:35 ` Tejun Heo
2021-09-10 2:12 ` taoyi.ty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8d68c6-9a1c-dc19-e430-e044e4c4f210@linux.alibaba.com \
--to=escape@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mcgrof@kernel.org \
--cc=shanpeic@linux.alibaba.com \
--cc=tj@kernel.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox