From: Rik van Riel <riel@surriel.com>
To: Joanne Koong <joannelkoong@gmail.com>,
akpm@linux-foundation.org, hannes@cmpxchg.org,
shakeel.butt@linux.dev, roman.gushchin@linux.dev,
willy@infradead.org, jack@suse.cz
Cc: mhocko@suse.com, muchun.song@linux.dev, david@kernel.org,
ljs@kernel.org, vbabka@kernel.org, liam@infradead.org,
rppt@kernel.org, surenb@google.com, linux-mm@kvack.org,
cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] mm: memcontrol: factor reclaim logic out of try_charge_memcg()
Date: Mon, 05 Oct 2026 14:49:48 -0400 [thread overview]
Message-ID: <822e26563419d8e3ffc13c43603ef79d4820503a.camel@surriel.com> (raw)
In-Reply-To: <20261003001555.3498357-2-joannelkoong@gmail.com>
On Fri, 2026-10-02 at 17:15 -0700, Joanne Koong wrote:
> Move reclaim logic in try_charge_memcg() into helper functions so
> that
> the next patch can reuse them.
>
> In memcg_charge_reclaim(), we can call memcg_memory_event() directly
> instead of passing in allow_spinning. allow_spinning must always be
> true
> here since memcg_charge_may_reclaim() has already checked that the
> gfp
> mask allows blocking, which implies spinning is also allowed.
>
> No functional changes.
>
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
>
Nice cleanup.
Reviewed-by: Rik van Riel <riel@surriel.com>
--
All Rights Reversed.
next prev parent reply other threads:[~2026-10-05 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 0:15 [PATCH v1 0/3] mm/readahead: avoid per-folio memcg reclaim Joanne Koong
2026-10-03 0:15 ` [PATCH v1 1/3] mm: memcontrol: factor reclaim logic out of try_charge_memcg() Joanne Koong
2026-10-05 18:49 ` Rik van Riel [this message]
2026-10-03 0:15 ` [PATCH v1 2/3] mm: memcontrol: add mem_cgroup_reclaim_for_batch() Joanne Koong
2026-10-03 0:15 ` [PATCH v1 3/3] mm/readahead: avoid per-folio memcg reclaim Joanne Koong
2026-10-05 12:26 ` [PATCH v1 0/3] " Jan Kara
2026-10-06 14:01 ` Joanne Koong
2026-10-07 15:30 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=822e26563419d8e3ffc13c43603ef79d4820503a.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=joannelkoong@gmail.com \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox