From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 428281DA10D for ; Wed, 4 Sep 2024 13:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725458011; cv=none; b=Hb1goD6VC0xOXWwxleMay9n2j+OVjOLlz6QFTW4ezw0JWRJ1F76RAGlhYnyocD+B/3x16JcuGiE1wawXriAsGlSeuGUfdsxQK3m+cpB2aX0ysP93HmGGr9G9+LkZVjL38ZU9X9tr6ivt986BIwA/J4R2d5euhyrDfASIu9I/Lg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725458011; c=relaxed/simple; bh=bCCy75tHcqfvZeyJUrW++3GDyn/NtOzf4apKrtPuliU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VeDMTLd6+imt1avLTxEN5VCQ7Z3vREgMv9URl22pH+LPR90kpfqlLIR5dp73W+T7L6WTJHSsxOb+9qtuNrKFaEcpHnMocN60Qj8PsDPB+Be/hack67o3YuOOo6GmWMQff4wLz16x1GoDdQK5uJs3MxSB4HFs954Bp9lKiqkVRdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=hS+jiD42; arc=none smtp.client-ip=209.85.166.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="hS+jiD42" Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-39d3872e542so25569255ab.2 for ; Wed, 04 Sep 2024 06:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1725458009; x=1726062809; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r7kTLsJyk/MZC3WNMNI51yi9z/rphbSOOoUjCA8uaQU=; b=hS+jiD42ovTUTXrGPKwMNlHJK4jmIQJHFnWuOci2WN+EtaiEsn9EgDSJSbAcN9hiit tP+zPzXU7/cOtUaXqvlYcKF1Y6jyvyEOdpbpuid/NM1kUbNyoQx2nXGmkWQMO6lTfeP/ EIv3RjTyOXtDeKvae6MfJgcit22cIkOYnSGqwh4ZDthm//yc8Rb0v4qIehsz0W1GjI8C PC7ann68RESdFHynVlWlWSEGrGQ9BdO2CYlWXsAZDeVSt1+N21+AwRZ5fTytNJntWNyd OXtRihc+bJ7WijOX6PbFyGqeivUxq4QxePjTPBjMWdZzK3nXYEC7vOARZjFpXEFl74ea e/Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725458009; x=1726062809; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r7kTLsJyk/MZC3WNMNI51yi9z/rphbSOOoUjCA8uaQU=; b=EI6W53q+isyKFrZ/GpoFuQUpzv2mgVyY5svrCGWxisiwiBO/1bz9EOmhCPfkGE8hyy gY34NS8GoKc/hKBaM9AyTGX82MBuacEVXRwoG37tBz8Uw6b2UA8Eg0pbVcLs9xL0DUyD +Yvr60lOG6Y244XeS4m/HypuxqCtYuWjkQIU/YLvOHsfdCOz/ap3YGE/sMs9kodnCRQR cbxpQpK88FRBwna+P/qnuHoXxEC6gqA9fvKOVOqmKDu9tQ7w6Y7nYlSxiiSlnAJZ6AMI 82BR+jcjCdBFEI5+WXH0IukHw54WtS//Q8xBA/0j+Gw2vwzH+Q1NZyb2cNMS+RMiGlZT bzTw== X-Gm-Message-State: AOJu0YxHSpYUag93utaNYGcVnLZdoSNfvy17B4nzB/rJZvKw+YMOHRoj HqzXdBHBHWbM6RIC+O4rO15QB7x2nPAiMkxm/3PZCOKWk4i5OMaJpw6hN00hskk= X-Google-Smtp-Source: AGHT+IFbfJF6J1NLerOOEjFSrOLoyu7FtfSqVr0k9qMXD7kZr+v8XYpOfZHf8UT9kcO7HZL9AquDwQ== X-Received: by 2002:a05:6e02:160e:b0:382:64d9:1cba with SMTP id e9e14a558f8ab-39f4f55f3d9mr163683405ab.19.1725458009221; Wed, 04 Sep 2024 06:53:29 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d06a1c5cdesm5424173.81.2024.09.04.06.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 06:53:28 -0700 (PDT) Message-ID: <850a38fb-79dc-420e-ad85-1a0168f9e63d@kernel.dk> Date: Wed, 4 Sep 2024 07:53:27 -0600 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-6.12 0/4] block, bfq: fix corner cases related to bfqq merging To: Yu Kuai , jack@suse.cz, tj@kernel.org, josef@toxicpanda.com, paolo.valente@unimore.it, mauro.andreolini@unimore.it, avanzini.arianna@gmail.com Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" References: <20240902130329.3787024-1-yukuai1@huaweicloud.com> <2ee05037-fb4f-4697-958b-46f0ae7d9cdd@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/3/24 7:32 PM, Yu Kuai wrote: > Hi, > > 在 2024/09/03 23:51, Jens Axboe 写道: >> On 9/2/24 7:03 AM, Yu Kuai wrote: >>> From: Yu Kuai >>> >>> Our syzkaller report a UAF problem(details in patch 1), however it can't >>> be reporduced. And this set are some corner cases fix that might be >>> related, and they are found by code review. >>> >>> Yu Kuai (4): >>>    block, bfq: fix possible UAF for bfqq->bic with merge chain >>>    block, bfq: choose the last bfqq from merge chain in >>>      bfq_setup_cooperator() >>>    block, bfq: don't break merge chain in bfq_split_bfqq() >>>    block, bfq: use bfq_reassign_last_bfqq() in bfq_bfqq_move() >>> >>>   block/bfq-cgroup.c  |  7 +------ >>>   block/bfq-iosched.c | 17 +++++++++++------ >>>   block/bfq-iosched.h |  2 ++ >>>   3 files changed, 14 insertions(+), 12 deletions(-) >> >> BFQ is effectively unmaintained, and has been for quite a while at >> this point. I'll apply these, thanks for looking into it, but I think we >> should move BFQ to an unmaintained state at this point. > > Sorry to hear that, we would be willing to take on the responsibility of > maintaining this code, please let me know if there are any specific > guidelines or processes we should follow. We do have customers are using > bfq in downstream kernels, and we are still running lots of test for > bfq. Most important is just reviewing fixes and tending to bug reports, and then collecting those fixes and sending them out to the list+me for inclusion. Not much more needs to happen, this series is a good example of it. -- Jens Axboe