From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v4 4/5] genirq/affinity: allow driver's discontigous affinity set Date: Sat, 01 Feb 2020 10:08:36 +0100 Message-ID: <871rrevfmz.fsf@nanos.tec.linutronix.de> References: Mime-Version: 1.0 Return-path: In-Reply-To: Sender: linux-block-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Weiping Zhang , axboe@kernel.dk, tj@kernel.org, hch@lst.de, bvanassche@acm.org, keith.busch@intel.com, minwoo.im.dev@gmail.com, edmund.nadolski@intel.com Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-nvme@lists.infradead.org Weiping Zhang writes: > nvme driver will add 4 sets for supporting NVMe weighted round robin, > and some of these sets may be empty(depends on user configuration), > so each particular set is assigned one static index for avoiding the > management trouble, then the empty set will be been by > irq_create_affinity_masks(). What's the point of an empty interrupt set in the first place? This does not make sense and smells like a really bad hack. Can you please explain in detail why this is required and why it actually makes sense? Thanks, tglx