From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH 07/10] cgroup: remove cgroup_add_file[s]() Date: Tue, 20 Mar 2012 14:17:51 +0530 Message-ID: <87aa3bu094.fsf@linux.vnet.ibm.com> References: <1331940963-15756-1-git-send-email-tj@kernel.org> <1331940963-15756-8-git-send-email-tj@kernel.org>User-Agent: Notmuch/0.11.1+346~g13d19c3 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Mime-Version: 1.0 Return-path: In-Reply-To: <1331940963-15756-8-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo , glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Tejun Heo Tejun Heo writes: > No controller is using cgroup_add_files[s](). Unexport them, and > convert cgroup_add_files() to handle NULL entry terminated array > instead of taking count explicitly and continue creation on failure > for internal use. > I am planning to use that in the HugeTLB extension of memcg. http://article.gmane.org/gmane.linux.kernel.mm/75470 We need to have different limit and usage file for different HugeTLB page size supported. -aneesh