From: "Aneesh Kumar K.V" <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
mgorman-l3A5Bk7waGM@public.gmane.org,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH -V4 05/10] hugetlb: add charge/uncharge calls for HugeTLB alloc/free
Date: Wed, 28 Mar 2012 23:09:34 +0530 [thread overview]
Message-ID: <87sjgs1v6x.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <20120328131706.GF20949-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org> writes:
> On Fri 16-03-12 23:09:25, Aneesh Kumar K.V wrote:
>> From: "Aneesh Kumar K.V" <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>>
>> This adds necessary charge/uncharge calls in the HugeTLB code
>
> This begs for more description...
> Other than that it looks correct.
>
Updated as below
hugetlb: add charge/uncharge calls for HugeTLB alloc/free
This adds necessary charge/uncharge calls in the HugeTLB code. We do
memcg charge in page alloc and uncharge in compound page destructor.
We also need to ignore HugeTLB pages in __mem_cgroup_uncharge_common
because that get called from delete_from_page_cache
-aneesh
next prev parent reply other threads:[~2012-03-28 17:39 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 17:39 [PATCH -V4 00/10] memcg: Add memcg extension to control HugeTLB allocation Aneesh Kumar K.V
2012-03-16 17:39 ` [PATCH -V4 01/10] hugetlb: rename max_hstate to hugetlb_max_hstate Aneesh Kumar K.V
2012-03-19 2:07 ` KAMEZAWA Hiroyuki
[not found] ` <1331919570-2264-2-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-28 9:18 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 02/10] hugetlbfs: don't use ERR_PTR with VM_FAULT* values Aneesh Kumar K.V
[not found] ` <1331919570-2264-3-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 2:11 ` KAMEZAWA Hiroyuki
2012-03-19 6:37 ` Aneesh Kumar K.V
2012-03-28 9:25 ` Michal Hocko
[not found] ` <20120328092547.GC20949-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-03-28 11:35 ` Aneesh Kumar K.V
2012-03-16 17:39 ` [PATCH -V4 03/10] hugetlbfs: Add an inline helper for finding hstate index Aneesh Kumar K.V
2012-03-19 2:15 ` KAMEZAWA Hiroyuki
2012-03-28 9:41 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 04/10] memcg: Add HugeTLB extension Aneesh Kumar K.V
[not found] ` <1331919570-2264-5-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 2:38 ` KAMEZAWA Hiroyuki
[not found] ` <4F669C2E.1010502-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-03-19 6:52 ` Aneesh Kumar K.V
[not found] ` <874ntlkrp6.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 7:00 ` KAMEZAWA Hiroyuki
2012-03-19 11:39 ` Glauber Costa
2012-03-19 12:07 ` KAMEZAWA Hiroyuki
[not found] ` <4F671AE6.5020204-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-03-21 4:48 ` Aneesh Kumar K.V
[not found] ` <87obrqsgno.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-21 5:22 ` KAMEZAWA Hiroyuki
2012-03-28 11:33 ` Michal Hocko
2012-03-28 13:40 ` Aneesh Kumar K.V
2012-03-28 15:44 ` Michal Hocko
2012-03-28 13:40 ` Michal Hocko
[not found] ` <20120328134020.GG20949-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-03-28 17:37 ` Aneesh Kumar K.V
[not found] ` <87y5qk1vat.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-03-29 0:18 ` KAMEZAWA Hiroyuki
2012-03-29 7:57 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 05/10] hugetlb: add charge/uncharge calls for HugeTLB alloc/free Aneesh Kumar K.V
[not found] ` <1331919570-2264-6-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 2:41 ` KAMEZAWA Hiroyuki
2012-03-19 7:01 ` Aneesh Kumar K.V
2012-03-28 13:17 ` Michal Hocko
[not found] ` <20120328131706.GF20949-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-03-28 17:39 ` Aneesh Kumar K.V [this message]
2012-03-29 8:10 ` Michal Hocko
2012-03-30 10:40 ` Aneesh Kumar K.V
[not found] ` <871uoamkxr.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-03-30 10:46 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 06/10] memcg: track resource index in cftype private Aneesh Kumar K.V
[not found] ` <1331919570-2264-7-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 2:43 ` KAMEZAWA Hiroyuki
2012-03-16 17:39 ` [PATCH -V4 07/10] hugetlbfs: Add memcg control files for hugetlbfs Aneesh Kumar K.V
2012-03-19 2:56 ` KAMEZAWA Hiroyuki
[not found] ` <4F66A059.20801-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-03-19 7:14 ` Aneesh Kumar K.V
[not found] ` <87wr6hjc58.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 7:34 ` KAMEZAWA Hiroyuki
2012-03-20 9:22 ` Aneesh Kumar K.V
2012-03-16 17:39 ` [PATCH -V4 08/10] hugetlbfs: Add a list for tracking in-use HugeTLB pages Aneesh Kumar K.V
[not found] ` <1331919570-2264-9-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 3:00 ` KAMEZAWA Hiroyuki
2012-03-19 8:59 ` Aneesh Kumar K.V
2012-03-28 13:58 ` Michal Hocko
2012-03-28 17:38 ` Aneesh Kumar K.V
2012-03-29 8:11 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 09/10] memcg: move HugeTLB resource count to parent cgroup on memcg removal Aneesh Kumar K.V
[not found] ` <1331919570-2264-10-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-19 3:04 ` KAMEZAWA Hiroyuki
2012-03-19 9:00 ` Aneesh Kumar K.V
2012-03-28 14:07 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 10/10] memcg: Add memory controller documentation for hugetlb management Aneesh Kumar K.V
[not found] ` <1331919570-2264-11-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-28 14:36 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjgs1v6x.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mgorman-l3A5Bk7waGM@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).