Re: [PATCH] blk-cgroup: fix wrong unlock order when parse per blkg config

[Joseph Qi <jiangqi903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi Tejun,
	
I've checked the upstream mainline and found that this is already fixed
as part of your commit 457e490f2b74 ("blkcg: allocate struct blkcg_gq
outside request queue spinlock"). So I do not have to resend it any
more, thanks.

Thanks,
Joseph

On 17/5/2 08:41, Joseph Qi wrote:
> Fine, I will explain so and resend it later.
> 
> Thanks,
> Joseph
> 
> On 17/4/29 05:22, Tejun Heo wrote:
>> Hello,
>>
>> On Mon, Apr 24, 2017 at 06:52:05PM +0800, Joseph Qi wrote:
>>> From: Joseph Qi <qijiang.qj-gPhfCIXyaqCqndwCJWfcng@public.gmane.org>
>>>
>>> In case of error blkg in blkg_conf_prep, we should unlock
>>> queue->queue_lock first and then rcu, just like blkg_conf_finish.
>>
>> I get that this is inconsistent but why is this wrong?  If this is for
>> consistency, can you please explain so in the commit so that people
>> don't confuse it for an actual bug fix?
>>
>> Thanks.
>>