From: Waiman Long <longman@redhat.com>
To: Xiongwei Song <xiongwei.song@windriver.com>,
lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org,
corbet@lwn.net
Cc: vbabka@suse.cz, yosryahmed@google.com, rostedt@goodmis.org,
cl@linux.com, chengming.zhou@linux.dev, zhengyejian1@huawei.com,
cgroups@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cgroup/cpuset: Remove cpuset_do_slab_mem_spread()
Date: Thu, 29 Feb 2024 09:29:29 -0500 [thread overview]
Message-ID: <90394965-e2a4-4915-a717-eef75f660dfb@redhat.com> (raw)
In-Reply-To: <20240229142007.1278610-1-xiongwei.song@windriver.com>
On 2/29/24 09:20, Xiongwei Song wrote:
> The SLAB allocator has been removed sine 6.8-rc1 [1], so there is no user
> with SLAB_MEM_SPREAD and cpuset_do_slab_mem_spread(). Then SLAB_MEM_SPREAD
> is marked as unused by [2]. Here we can remove
> cpuset_do_slab_mem_spread(). For more details, please check [3].
>
> [1] https://lore.kernel.org/linux-mm/20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz/
> [2] https://lore.kernel.org/linux-kernel/20240223-slab-cleanup-flags-v2-0-02f1753e8303@suse.cz/T/
> [3] https://lore.kernel.org/lkml/32bc1403-49da-445a-8c00-9686a3b0d6a3@redhat.com/T/#mf14b838c5e0e77f4756d436bac3d8c0447ea4350
>
> Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com>
> ---
> include/linux/cpuset.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> index 875d12598bd2..0ce6ff0d9c9a 100644
> --- a/include/linux/cpuset.h
> +++ b/include/linux/cpuset.h
> @@ -121,11 +121,6 @@ static inline int cpuset_do_page_mem_spread(void)
> return task_spread_page(current);
> }
>
> -static inline int cpuset_do_slab_mem_spread(void)
> -{
> - return task_spread_slab(current);
> -}
> -
> extern bool current_cpuset_is_being_rebound(void);
>
> extern void rebuild_sched_domains(void);
> @@ -264,11 +259,6 @@ static inline int cpuset_do_page_mem_spread(void)
> return 0;
> }
>
> -static inline int cpuset_do_slab_mem_spread(void)
> -{
> - return 0;
> -}
> -
> static inline bool current_cpuset_is_being_rebound(void)
> {
> return false;
Reviewed-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2024-02-29 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 14:20 [PATCH 1/2] cgroup/cpuset: Remove cpuset_do_slab_mem_spread() Xiongwei Song
2024-02-29 14:20 ` [PATCH 2/2] cgroup/cpuset: Mark memory_spread_slab as obsolete Xiongwei Song
2024-02-29 14:30 ` Waiman Long
2024-02-29 20:29 ` Tejun Heo
2024-02-29 14:29 ` Waiman Long [this message]
2024-02-29 20:28 ` [PATCH 1/2] cgroup/cpuset: Remove cpuset_do_slab_mem_spread() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90394965-e2a4-4915-a717-eef75f660dfb@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=xiongwei.song@windriver.com \
--cc=yosryahmed@google.com \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox