Re: [PATCH] blk-iocost: fix seq_printf compile type mismatch error

Carlos Bilbao
2023-07-18T15:37:23Z

On 7/17/23 13:49, Tejun Heo wrote:
> On Mon, Jul 17, 2023 at 09:18:52AM -0500, Carlos Bilbao wrote:
>> From: amd <amd-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
>>
>> Fix two type mismatch errors encountered while compiling blk-iocost.c with
>> GCC version 13.1.1 that involved constant operator WEIGHT_ONE. Cast the
>> result of the division operation to (unsigned int) to match the expected
>> format specifier %u in two seq_printf invocations.
>
> Can you detail the warnings? Was that on 32bit compiles?

The concrete error was: "format ‘%u’ expects argument of type ‘unsigned
int’, but argument 3 has type ‘long unsigned int’". If I run:

$ echo | cpp -dM | grep __LP64__
#define __LP64__ 1

which makes me believe it is not 32 bits.

>
> Thanks.
>

Thanks,
Carlos