Linux cgroups development
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Guopeng Zhang <guopeng.zhang@linux.dev>,
	Tejun Heo <tj@kernel.org>, Ridong Chen <ridong.chen@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Michal Koutny <mkoutny@suse.com>, Shuah Khan <shuah@kernel.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Guopeng Zhang <zhangguopeng@kylinos.cn>
Subject: Re: [PATCH v2 3/3] selftests/cgroup: Add test for preserving boot-isolated CPUs
Date: Mon, 24 Aug 2026 10:18:09 -0400	[thread overview]
Message-ID: <9a81a131-0e2c-480f-95db-1a4919ee2e15@redhat.com> (raw)
In-Reply-To: <20260824020140.21130-4-guopeng.zhang@linux.dev>

On 8/23/26 10:01 PM, Guopeng Zhang wrote:
> From: Guopeng Zhang <zhangguopeng@kylinos.cn>
>
> Put a CPU isolated at boot into an isolated partition, change the
> partition back to member and check that the CPU remains isolated.
>
> Signed-off-by: Guopeng Zhang <zhangguopeng@kylinos.cn>
> ---
>   .../selftests/cgroup/test_cpuset_prs.sh       | 58 +++++++++++++++++++
>   1 file changed, 58 insertions(+)
>
> diff --git a/tools/testing/selftests/cgroup/test_cpuset_prs.sh b/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> index fdb3185570d4..131d8b4551ef 100755
> --- a/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> +++ b/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> @@ -1155,6 +1155,63 @@ test_isolated()
>   	pause 0.05
>   }
>   
> +#
> +# Select an online CPU isolated from scheduler domains at boot.
> +# $1: test name used in the skip message
> +#
> +get_boot_isolated_cpu()
> +{
> +	TEST_NAME=$1
> +	BOOT_ISOLATED_FILE=/sys/devices/system/cpu/isolated
> +
> +	[[ -r $BOOT_ISOLATED_FILE ]] || {
> +		echo "$TEST_NAME test SKIPPED: boot isolation state unavailable"
> +		return 1
> +	}
> +	BOOT_CPUS=$(cat $BOOT_ISOLATED_FILE)
> +	[[ -n "$BOOT_CPUS" ]] || {
> +		echo "$TEST_NAME test SKIPPED: no boot-isolated CPU"
> +		return 1
> +	}
> +
> +	BOOT_CPU=$(echo "$BOOT_CPUS" | sed -e 's/[,-].*//')
> +	CPU_ONLINE=/sys/devices/system/cpu/cpu${BOOT_CPU}/online
> +	[[ ! -e $CPU_ONLINE || $(cat $CPU_ONLINE) -eq 1 ]] || {
> +		echo "$TEST_NAME test SKIPPED: CPU $BOOT_CPU is offline"
> +		return 1
> +	}
> +}
> +
> +#
> +# A CPU isolated at boot must stay isolated after it is released by a dynamic
> +# isolated partition.
> +#
> +test_boot_isolated()
> +{
> +	TEST_NAME="Boot-isolated CPU partition release"
> +	get_boot_isolated_cpu "$TEST_NAME" || return 0
> +	echo "Running $TEST_NAME test ..."
> +
> +	cd $CGROUP2/test
> +	echo member > cpuset.cpus.partition
> +	echo $BOOT_CPU > cpuset.cpus
> +	[[ $(cat cpuset.cpus.effective) = "$BOOT_CPU" ]] || {
> +		echo "$TEST_NAME test SKIPPED: CPU $BOOT_CPU is unavailable"
> +		echo "" > cpuset.cpus
> +		cd $CGROUP2
> +		return 0
> +	}
> +	test_partition isolated
> +	test_partition member
> +	check_isolcpus "." || {
> +		echo "Boot-isolated CPU $BOOT_CPU was lost after partition release"
> +		exit 1
> +	}
> +	echo "" > cpuset.cpus
> +	cd $CGROUP2
> +	echo "$TEST_NAME test PASSED."
> +}
> +
>   #
>   # Wait for inotify event for the given file and read it
>   # $1: cgroup file to wait for
> @@ -1226,5 +1283,6 @@ trap cleanup 0 2 3 6
>   run_state_test TEST_MATRIX
>   run_remote_state_test REMOTE_TEST_MATRIX
>   test_isolated
> +test_boot_isolated
>   test_inotify
>   echo "All tests PASSED."
Reviewed-by: Waiman Long <longman@redhat.com>


  reply	other threads:[~2026-08-24 14:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24  2:01 [PATCH v2 0/3] cgroup/cpuset: Preserve boot-isolated CPUs on partition release Guopeng Zhang
2026-08-24  2:01 ` [PATCH v2 1/3] selftests/cgroup: Drop invalid boot isolation comparison Guopeng Zhang
2026-08-24  3:23   ` Waiman Long
2026-08-24  2:01 ` [PATCH v2 2/3] cgroup/cpuset: Preserve boot-isolated CPUs on partition release Guopeng Zhang
2026-08-24 14:17   ` Waiman Long
2026-08-24  2:01 ` [PATCH v2 3/3] selftests/cgroup: Add test for preserving boot-isolated CPUs Guopeng Zhang
2026-08-24 14:18   ` Waiman Long [this message]
2026-08-24 17:04 ` [PATCH v2 0/3] cgroup/cpuset: Preserve boot-isolated CPUs on partition release Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a81a131-0e2c-480f-95db-1a4919ee2e15@redhat.com \
    --to=longman@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=guopeng.zhang@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=ridong.chen@linux.dev \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    --cc=zhangguopeng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox