From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8232F3FF4; Sat, 13 Apr 2024 20:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713041807; cv=none; b=EPXuKOpoO1lMhCztNF5ABi3pq1a6LrqCbPjARsIKueYkhoc3IQZo4fSC4Jw71joHiRJhBhAIQ1t3fnCjsUg9wVc3+aLBqQTrI61sytSFUSidnch3HkIOMBWZouAN0rI+I9vHQhHTbRR6dQ5T6Q+PyNyi0X9WhOIL03O5pBrRVS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713041807; c=relaxed/simple; bh=j6SPsFOqCMJ2cexdWS6A1CoYES7H/ZCka9uTlYN0nGw=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=OwptOwF8zQocyzFDarTe9ibAKNGCJI0mcVcIQj/J/JBXJrtyhQtsjeczNLG0phPnEhc0Z0+Rn7iVpbQ1eu7YKhW3r0rEjVGNuG3zBRG9QyaC8PAdmw3wrzSfKS8XR2V8lVviPrwRK49uoAzAdSfZ8b5yYsyXMMontGE/bcfD9C4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oLA6zCxA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oLA6zCxA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7EB8C113CD; Sat, 13 Apr 2024 20:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713041806; bh=j6SPsFOqCMJ2cexdWS6A1CoYES7H/ZCka9uTlYN0nGw=; h=Date:To:Cc:Subject:From:References:In-Reply-To:From; b=oLA6zCxAvYFwl6Zc67W9UlBsuofL84TItfzvWvZC+srQ2cYuTJo4hDcOw4kBEMrjw fFY3cSjqj20Z7EvBJWTJdcLns6o9++IALyTWoKwq2vRgSGmqMbya17JpavOSbmg0fv OWYO1FINy1RwOgqwdtfWhhBBUHLYbaxe74Xfm/njE/fsoLHp5b4tv/2gPFlxB4ikhY wfbNZRmwVLv1m/zNf4onr4rR+jx/BBxlYaJB4TG3XSZuG8g149XFbNVdpkISMtukYO T1FFI89SsrIraaBY2M3Kuvg2979AqUMfDtb2k9hiJI2St9FCL3HFkRxYfPdAK031bW c/9LqCkkqpmQg== Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 13 Apr 2024 23:56:40 +0300 Message-Id: To: "Huang, Kai" , "Mehta, Sohil" , "mingo@redhat.com" , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "cgroups@vger.kernel.org" , "hpa@zytor.com" , "tim.c.chen@linux.intel.com" , "linux-sgx@vger.kernel.org" , "mkoutny@suse.com" , "haitao.huang@linux.intel.com" , "tglx@linutronix.de" , "tj@kernel.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" Cc: "mikko.ylinen@linux.intel.com" , "seanjc@google.com" , "anakrish@microsoft.com" , "Zhang, Bo" , "kristen@linux.intel.com" , "yangjie@microsoft.com" , "Li, Zhiquan1" , "chrisyan@microsoft.com" Subject: Re: [PATCH v10 08/14] x86/sgx: Add basic EPC reclamation flow for cgroup From: "Jarkko Sakkinen" X-Mailer: aerc 0.17.0 References: <20240328002229.30264-1-haitao.huang@linux.intel.com> <20240328002229.30264-9-haitao.huang@linux.intel.com> <0e406b207c7769359d45ba4e4594174e64ec3faa.camel@intel.com> In-Reply-To: <0e406b207c7769359d45ba4e4594174e64ec3faa.camel@intel.com> On Fri Apr 5, 2024 at 6:07 AM EEST, Huang, Kai wrote: > On Thu, 2024-04-04 at 12:05 -0500, Haitao Huang wrote: > > > > -static inline int sgx_cgroup_try_charge(struct sgx_cgroup *sgx_cg) > > > > +static inline int sgx_cgroup_try_charge(struct sgx_cgroup *sgx_cg,= =C2=A0=20 > > > > enum sgx_reclaim r) > > >=20 > > > Is the @r here intentional for shorter typing? > > >=20 > >=20 > > yes :-) > > Will speel out to make it consistent if that's the concern. > > I kinda prefer the full name to match the CONFIG_CGROUP_SGX_EPC on case. = You > can put the 'enum sgx_reclaim reclaim' parameter into the new line if nee= ded: Why don't cgroups for SGX get always enabled when SGX and cgroups support are enabled? BR, Jarkko