From: Josef Bacik <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>
To: Kemeng Shi <shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] block: Correct comment for scale_cookie_change
Date: Mon, 17 Oct 2022 14:20:55 -0400 [thread overview]
Message-ID: <Y02dBx/nNwMLUxXm@localhost.localdomain> (raw)
In-Reply-To: <20220929074055.30080-3-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Thu, Sep 29, 2022 at 03:40:54PM +0800, Kemeng Shi wrote:
> Default queue depth of iolatency_grp is unlimited, so we scale down
> quickly(once by half) in scale_cookie_change. Remove the "subtract
> 1/16th" part which is not the truth.
>
Ok sure, but at least update the comment to indicate what we actually do when
scaling down. Thanks,
Josef
next prev parent reply other threads:[~2022-10-17 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 7:40 [PATCH 0/3] A few cleanup patches for blk-iolatency.c Kemeng Shi
2022-09-29 7:40 ` [PATCH 1/3] block: Remove redundant parent blkcg_gp check in check_scale_change Kemeng Shi
2022-10-17 18:23 ` Josef Bacik
2022-09-29 7:40 ` [PATCH 2/3] block: Correct comment for scale_cookie_change Kemeng Shi
[not found] ` <20220929074055.30080-3-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-10-17 18:20 ` Josef Bacik [this message]
2022-09-29 7:40 ` [PATCH 3/3] block: Replace struct rq_depth with unsigned int in struct iolatency_grp Kemeng Shi
[not found] ` <20220929074055.30080-4-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-10-17 18:27 ` Josef Bacik
[not found] ` <20220929074055.30080-1-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-10-17 2:06 ` [PATCH 0/3] A few cleanup patches for blk-iolatency.c Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y02dBx/nNwMLUxXm@localhost.localdomain \
--to=josef-digfwca+lfgyejad7bwfqa@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).