From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Kemeng Shi <shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] blk-cgroup: Remove unnecessary blk_ioprio_exit in blkcg_init_queue
Date: Mon, 10 Oct 2022 00:37:38 -0700 [thread overview]
Message-ID: <Y0PLwj/l/l4QPpTC@infradead.org> (raw)
In-Reply-To: <20221010023859.11896-2-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Mon, Oct 10, 2022 at 10:38:56AM +0800, Kemeng Shi wrote:
> Function blk_ioprio_init only alloc blkg_policy_data which will be freed
> in blkg_destroy_all, so no blk_ioprio_exit is called when blk_throtl_init
> is failed in blkcg_init_queue. Also blk_ioprio_exit is not called in
> blkcg_exit_queue for the same reason. Just remove blk_ioprio_exit to
> keep behavior consistent.
This code looks very different in current mainline.
next prev parent reply other threads:[~2022-10-10 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 2:38 [PATCH 0/4] A few cleanup patches for blk-cgroup Kemeng Shi
2022-10-10 2:38 ` [PATCH 1/4] blk-cgroup: Remove unnecessary blk_ioprio_exit in blkcg_init_queue Kemeng Shi
[not found] ` <20221010023859.11896-2-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-10-10 7:37 ` Christoph Hellwig [this message]
2022-10-11 1:04 ` Kemeng Shi
2022-10-10 2:38 ` [PATCH 2/4] blk-cgroup: correct comment for blk_alloc_queue and blk_exit_queue Kemeng Shi
[not found] ` <20221010023859.11896-3-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-10-10 20:26 ` Tejun Heo
[not found] ` <Y0SACpAv4+ETrS6Z-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-10-11 1:07 ` Kemeng Shi
2022-10-10 2:38 ` [PATCH 3/4] blk-cgroup: Add NULL check of pd_alloc_fn in blkcg_activate_policy Kemeng Shi
2022-10-10 20:29 ` Tejun Heo
[not found] ` <Y0SAneaJadYJwAkr-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-10-11 1:23 ` Kemeng Shi
2022-10-11 7:53 ` Yu Kuai
2022-10-10 2:38 ` [PATCH 4/4] blk-cgroup: Fix typo in comment Kemeng Shi
2022-10-10 20:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0PLwj/l/l4QPpTC@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox