public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
Cc: "Huang,
	Ying" <ying.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Aneesh Kumar K V
	<aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
	<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Hansen,
	Dave" <dave.hansen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"Chen,
	Tim C" <tim.c.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"Yin,
	Fengwei" <fengwei.yin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] mm/vmscan: respect cpuset policy during page demotion
Date: Mon, 31 Oct 2022 22:09:15 +0800	[thread overview]
Message-ID: <Y1/XC+witPxFj04T@feng-clx> (raw)
In-Reply-To: <Y1+J7+1V1nJXF+3b-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

On Mon, Oct 31, 2022 at 04:40:15PM +0800, Michal Hocko wrote:
> On Fri 28-10-22 07:22:27, Huang, Ying wrote:
> > Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org> writes:
> > 
> > > On Thu 27-10-22 17:31:35, Huang, Ying wrote:
> [...]
> > >> I think that it's possible for different processes have different
> > >> requirements.
> > >> 
> > >> - Some processes don't care about where the memory is placed, prefer
> > >>   local, then fall back to remote if no free space.
> > >> 
> > >> - Some processes want to avoid cross-socket traffic, bind to nodes of
> > >>   local socket.
> > >> 
> > >> - Some processes want to avoid to use slow memory, bind to fast memory
> > >>   node only.
> > >
> > > Yes, I do understand that. Do you have any specific examples in mind?
> > > [...]
> > 
> > Sorry, I don't have specific examples.
> 
> OK, then let's stop any complicated solution right here then. Let's
> start simple with a per-mm flag to disable demotion of an address space.
> Should there ever be a real demand for a more fine grained solution
> let's go further but I do not think we want a half baked solution
> without real usecases.

Yes, the concern about the high cost for mempolicy from you and Yang is
valid. 

How about the cpuset part? We've got bug reports from different channels
about using cpuset+docker to control meomry placement in memory tiering
system, leading to 2 commits solving them:

2685027fca38 ("cgroup/cpuset: Remove cpus_allowed/mems_allowed setup in
cpuset_init_smp()") 
https://lore.kernel.org/all/20220419020958.40419-1-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/

8ca1b5a49885 ("mm/page_alloc: detect allocation forbidden by cpuset and
bail out early")
https://lore.kernel.org/all/1632481657-68112-1-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/

From these bug reports, I think it's reasonable to say there are quite
some real world users using cpuset+docker+memory-tiering-system. So
I plan to refine the original cpuset patch with some optimizations
discussed (like checking once for kswapd based shrink_folio_list()).

Thanks,
Feng

> -- 
> Michal Hocko
> SUSE Labs
> 

  parent reply	other threads:[~2022-10-31 14:09 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26  7:43 [PATCH] mm/vmscan: respect cpuset policy during page demotion Feng Tang
     [not found] ` <20221026074343.6517-1-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-10-26  7:49   ` Aneesh Kumar K V
     [not found]     ` <dc453287-015d-fd1c-fe7f-6ee45772d6aa-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
2022-10-26  8:00       ` Feng Tang
2022-10-26  9:19         ` Michal Hocko
     [not found]           ` <Y1j7tsj5M0Md/+Er-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-26 10:42             ` Aneesh Kumar K V
     [not found]               ` <d17698d2-c1b5-9aa3-6271-838830d36cc5-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
2022-10-26 11:02                 ` Michal Hocko
     [not found]                   ` <Y1kTz1qjfsY1UBPf-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-26 12:08                     ` Aneesh Kumar K V
     [not found]                       ` <44e485d4-acf5-865d-17fe-13be1c1b430b-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
2022-10-26 12:21                         ` Michal Hocko
     [not found]                           ` <Y1kmOaXvzwRv/tza-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-26 12:35                             ` Aneesh Kumar K V
     [not found]                               ` <22590f74-ec91-e673-32df-8a04b4ab3931-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
2022-10-27  9:02                                 ` Michal Hocko
     [not found]                                   ` <Y1pJG+d+kXJgjNMc-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-27 10:16                                     ` Aneesh Kumar K V
     [not found]                                       ` <5a6c29f9-1154-03af-c22e-55108feb155f-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
2022-10-27 13:05                                         ` Michal Hocko
2022-10-26 12:20             ` Feng Tang
2022-10-26 15:59               ` Michal Hocko
     [not found]                 ` <Y1lZV6qHp3gIINGc-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-26 17:57                   ` Yang Shi
     [not found]                     ` <CAHbLzkppDPm87dx9-a7t3oP9DuZ0xCPC1UWr+E-s+vh12Gwb+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-10-27  7:11                       ` Feng Tang
2022-10-27  7:45                         ` Huang, Ying
     [not found]                           ` <87k04lk8vr.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-27  7:51                             ` Feng Tang
2022-10-27 17:55                         ` Yang Shi
     [not found]                           ` <CAHbLzkqvh3ry=FjQGuG--As2yYF2NU+bfvORqk1FyfE_vvTwXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-10-28  3:37                             ` Feng Tang
2022-10-28  5:54                               ` Huang, Ying
     [not found]                                 ` <87y1t0ijbk.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-28 17:23                                   ` Yang Shi
     [not found]                                     ` <CAHbLzkpO46yTiSVrKWRnABNW_PutuudEkB3RD-_YKxamW9SyaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-10-31  1:56                                       ` Huang, Ying
2022-10-31  2:19                                       ` Feng Tang
2022-10-28  5:09                             ` Aneesh Kumar K V
     [not found]                               ` <7b5f533d-4b2e-b45b-ee42-5e1cc3e8a279-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
2022-10-28 17:16                                 ` Yang Shi
     [not found]                                   ` <CAHbLzkrqaCF8wvtsAmvaZUqCAoRfO1qPSFyK7bVq5O5m1zuksg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-10-31  1:53                                     ` Huang, Ying
2022-10-27  6:47                   ` Huang, Ying
     [not found]                     ` <87wn8lkbk5.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-27  7:10                       ` Michal Hocko
     [not found]                         ` <Y1ou5DGHrEsKnhri-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-27  7:39                           ` Huang, Ying
     [not found]                             ` <87o7txk963.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-27  8:01                               ` Michal Hocko
     [not found]                                 ` <Y1o63SWD2KmQkT3v-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-27  9:31                                   ` Huang, Ying
     [not found]                                     ` <87fsf9k3yg.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-27 12:29                                       ` Michal Hocko
     [not found]                                         ` <Y1p5vaN1AWhpNWZx-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-27 23:22                                           ` Huang, Ying
     [not found]                                             ` <87bkpwkg24.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-31  8:40                                               ` Michal Hocko
     [not found]                                                 ` <Y1+J7+1V1nJXF+3b-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-10-31  8:51                                                   ` Huang, Ying
     [not found]                                                     ` <87wn8gcr5s.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-31  9:18                                                       ` Michal Hocko
2022-10-31 14:09                                                   ` Feng Tang [this message]
2022-10-31 14:32                                                     ` Michal Hocko
     [not found]                                                       ` <Y1/cgrgdVP+KdYzf-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-11-07  8:05                                                         ` Feng Tang
2022-11-07  8:17                                                           ` Michal Hocko
2022-11-01  3:17                                       ` Huang, Ying
2022-10-26  8:26   ` Yin, Fengwei
     [not found]     ` <22f86189-76fa-61ab-4e80-9c2740ec8e8a-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-10-26  8:37       ` Feng Tang
2022-10-26 14:36   ` Waiman Long
     [not found]     ` <da533477-da08-88cb-1e76-46364f1a6151-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-10-27  5:57       ` Feng Tang
2022-10-27  5:13   ` Huang, Ying
     [not found]     ` <878rl1luh1.fsf-fFUE1NP8JkzwuUmzmnQr+vooFf0ArEBIu+b9c/7xato@public.gmane.org>
2022-10-27  5:49       ` Feng Tang
2022-10-27  6:05         ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1/XC+witPxFj04T@feng-clx \
    --to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dave.hansen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=fengwei.yin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=mhocko-IBi9RG/b67k@public.gmane.org \
    --cc=tim.c.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=ying.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox