public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Haifeng Xu <haifeng.xu-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>
Cc: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
	lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: Simplify code in css_set_move_task
Date: Wed, 2 Nov 2022 16:31:33 -1000	[thread overview]
Message-ID: <Y2MoBeJGU1Exg6cX@slm.duckdns.org> (raw)
In-Reply-To: <25f6a188-4cc6-dace-1468-fd5645711515-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>

On Thu, Nov 03, 2022 at 10:13:22AM +0800, Haifeng Xu wrote:
> I understand your worries. Can I just check the populated state of
> css_set in 'css_set_update_populated' and don't change the order any
> more? I think it can also streamline 'css_set_move_task' a bit.

FWIW, I don't see much value in the proposed change. The resulting code
isn't better in any noticeable way. Even if the change were straightforward,
the value of the patch would seem questionable. There's no point in creating
code churns like this. Nothing is improved in any material way while
creating completely unnecessary risk for subtle breakages.

Thanks.

-- 
tejun

  parent reply	other threads:[~2022-11-03  2:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  7:47 [PATCH] cgroup: Simplify code in css_set_move_task haifeng.xu
     [not found] ` <20221020074701.84326-1-haifeng.xu-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>
2022-10-27  8:05   ` Michal Koutný
     [not found]     ` <20221027080558.GA23269-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-10-28 11:29       ` Haifeng Xu
     [not found]         ` <adb7418c-39a2-6202-970a-a039ad8201dd-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>
2022-10-31 13:11           ` Michal Koutný
     [not found]             ` <20221031131140.GC27841-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-11-03  2:13               ` Haifeng Xu
     [not found]                 ` <25f6a188-4cc6-dace-1468-fd5645711515-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>
2022-11-03  2:31                   ` Tejun Heo [this message]
2022-11-03 14:55                     ` Haifeng Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2MoBeJGU1Exg6cX@slm.duckdns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=haifeng.xu-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=mkoutny-IBi9RG/b67k@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox