From: Christoph Hellwig <hch@infradead.org>
To: Li Nan <linan122@huawei.com>
Cc: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH -next v2 1/9] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write()
Date: Wed, 30 Nov 2022 07:54:59 -0800 [thread overview]
Message-ID: <Y4d801NjwwT0voKA@infradead.org> (raw)
In-Reply-To: <20221130132156.2836184-2-linan122@huawei.com>
> + ret = nbytes;
ret is an int which bytes is a size_t. So we at least need a ssize_t
instead for ret, and even that assumes nbytes never overflows a ssize_t.
next prev parent reply other threads:[~2022-11-30 15:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 13:21 [PATCH -next v2 0/9] iocost bugfix Li Nan
2022-11-30 13:21 ` [PATCH -next v2 1/9] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write() Li Nan
2022-11-30 15:54 ` Christoph Hellwig [this message]
[not found] ` <Y4d801NjwwT0voKA-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-11-30 15:55 ` Christoph Hellwig
[not found] ` <20221130132156.2836184-2-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:31 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 2/9] blk-iocost: improve hanlder of match_u64() Li Nan
2022-11-30 20:32 ` Tejun Heo
[not found] ` <Y4e90zFnhhq764lP-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-01 2:15 ` Yu Kuai
[not found] ` <7e4f1cea-2691-9b81-35f6-0dd236149f56-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:08 ` Tejun Heo
2022-12-01 13:47 ` Yu Kuai
2022-11-30 13:21 ` [PATCH -next v2 4/9] blk-iocost: read params inside lock in sysfs apis Li Nan
[not found] ` <20221130132156.2836184-5-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:16 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 6/9] blk-iocost: change div64_u64 to DIV64_U64_ROUND_UP in ioc_refresh_params() Li Nan
[not found] ` <20221130132156.2836184-7-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:22 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 7/9] blk-iocost: fix UAF in ioc_pd_free Li Nan
[not found] ` <20221130132156.2836184-8-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:42 ` Tejun Heo
[not found] ` <Y4fAJpKcVL7Q9hgY-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-06 7:53 ` Yu Kuai
[not found] ` <20221130132156.2836184-1-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 13:21 ` [PATCH -next v2 3/9] blk-iocost: don't allow to configure bio based device Li Nan
[not found] ` <20221130132156.2836184-4-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:15 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 5/9] blk-iocost: fix divide by 0 error in calc_lcoefs() Li Nan
[not found] ` <20221130132156.2836184-6-linan122-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-30 20:20 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 8/9] block: fix null-pointer dereference in ioc_pd_init Li Nan
2022-11-30 20:50 ` Tejun Heo
2022-12-01 2:12 ` Yu Kuai
[not found] ` <9ca2b7ab-7fd3-a9a3-12a6-021a78886b54-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:11 ` Tejun Heo
[not found] ` <Y4h94m8QMPtS4xJV-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-01 10:23 ` Yu Kuai
2022-12-01 10:31 ` Tejun Heo
2022-12-05 9:32 ` Yu Kuai
[not found] ` <96487803-12cc-a694-0099-784106596fd1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-12 23:10 ` Tejun Heo
2022-11-30 13:21 ` [PATCH -next v2 9/9] blk-iocost: fix walk_list corruption Li Nan
2022-11-30 20:59 ` Tejun Heo
2022-12-01 1:19 ` Yu Kuai
[not found] ` <c028dd77-cabf-edd6-c893-8ee24762ac8c-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:00 ` Tejun Heo
[not found] ` <Y4h7RxdT83g+zFN0-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-01 10:14 ` Yu Kuai
[not found] ` <de04965e-1341-3053-0f4b-395b8390d00c-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-01 10:29 ` Tejun Heo
2022-12-05 9:35 ` Yu Kuai
2022-11-30 17:26 ` [PATCH -next v2 0/9] iocost bugfix Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4d801NjwwT0voKA@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linan122@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox