From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: tj@kernel.org, hch@infradead.org, josef@toxicpanda.com,
axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH -next 1/4] blk-iocost: track whether iocg is still online
Date: Wed, 21 Dec 2022 02:33:51 -0800 [thread overview]
Message-ID: <Y6LhD8CEkcgLUJoQ@infradead.org> (raw)
In-Reply-To: <20221217030527.1250083-2-yukuai1@huaweicloud.com>
On Sat, Dec 17, 2022 at 11:05:24AM +0800, Yu Kuai wrote:
> @@ -459,6 +459,8 @@ struct ioc_gq {
> struct blkg_policy_data pd;
> struct ioc *ioc;
>
> + bool online;
Nit: maybe tab align this field like the fields above it.
> +static void ioc_pd_offline(struct blkg_policy_data *pd)
> +{
> + struct ioc_gq *iocg = pd_to_iocg(pd);
> + struct ioc *ioc = iocg->ioc;
> + unsigned long flags;
> +
> + if (ioc) {
How could ioc be NULL here?
next prev parent reply other threads:[~2022-12-21 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 3:05 [PATCH -next 0/4] blk-iocost: make sure parent iocg is exited before child Yu Kuai
[not found] ` <20221217030527.1250083-1-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-17 3:05 ` [PATCH -next 1/4] blk-iocost: track whether iocg is still online Yu Kuai
2022-12-21 10:33 ` Christoph Hellwig [this message]
[not found] ` <Y6LhD8CEkcgLUJoQ-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-12-26 1:10 ` Yu Kuai
2022-12-17 3:05 ` [PATCH -next 2/4] blk-iocost: don't throttle bio if iocg is offlined Yu Kuai
2022-12-19 21:28 ` Tejun Heo
[not found] ` <Y6DXkLeOmu7VWovz-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-12-20 9:38 ` Yu Kuai
2022-12-17 3:05 ` [PATCH -next 3/4] blk-iocost: dispatch all throttled bio in ioc_pd_offline Yu Kuai
[not found] ` <20221217030527.1250083-4-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2022-12-19 21:31 ` Tejun Heo
2022-12-17 3:05 ` [PATCH -next 4/4] blk-iocost: guarantee the exit order of iocg Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6LhD8CEkcgLUJoQ@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox