From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 08/15] blk-wbt: open code wbt_queue_depth_changed in wbt_update_limits Date: Fri, 27 Jan 2023 13:56:38 -1000 Message-ID: References: <20230124065716.152286-1-hch@lst.de> <20230124065716.152286-9-hch@lst.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=LBcMmlP1oNR6HwzicKU5lpUtRWz5wSpADFnTmuSK9G4=; b=JekLdnK+ZQwksZmuaCiVS64kjOmWLje3UCcDBdnV9poXYxxuO+wkHGWpYnTJq7cAmU 7XZRUIICytVduVw1l40UPjKGwrrFde3ClLvR8MDo3QI5/Uoj7X9ZwY463+xFMh0nHsX/ 45Nz5HNkjA8BwSVUuxl9NY+ibbh873bLevbT9A718Ou6dQG5pFX/6qQtefVbYHWfRLZb EvP/H4NLJczStEuCukbH77eRYHjNXSDJS8yZszY8A6Q9gXy5FpZbxK7Zki4AVpeh+75F 2sWpeMNcxaN5AKttnaU2bkB/rDn+b00yFHKCerXGzrCvrTYWazvQe+CqZH1j8V08HyxS Iq3w== Sender: Tejun Heo Content-Disposition: inline In-Reply-To: <20230124065716.152286-9-hch-jcswGhMUV9g@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andreas Herrmann On Tue, Jan 24, 2023 at 07:57:08AM +0100, Christoph Hellwig wrote: > No real need to all the method here, so open code to it to prepare I might be being slow but can't understand what the first sentence is saying. I think making the descriptions a bit more detailed would be generally helpful. Thanks. -- tejun