From: Eric Biggers <ebiggers@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, stable@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH] fscrypt: Copy the memcg information to the ciphertext page
Date: Thu, 2 Feb 2023 17:07:24 -0800 [thread overview]
Message-ID: <Y9xeTDOmMZ75G6cq@sol.localdomain> (raw)
In-Reply-To: <Y9wrglzrfzTiCjh8@slm.duckdns.org>
On Thu, Feb 02, 2023 at 11:30:42AM -1000, Tejun Heo wrote:
> > The bug we're discussing here is that when ext4 writes out a pagecache page in
> > an encrypted file, it first encrypts the data into a bounce page, then passes
> > the bounce page (which don't have a memcg) to wbc_account_cgroup_owner(). Maybe
> > the proper fix is to just pass the pagecache page to wbc_account_cgroup_owner()
> > instead? See below for ext4 (a separate patch would be needed for f2fs):
>
> Yeah, this makes sense to me and is the right thing to do no matter what.
> wbc_account_cgroup_owner() should be fed the origin page so that the IO can
> be blamed on the owner of that page.
Thanks. These patches fix this for ext4 and f2fs:
* https://lore.kernel.org/r/20230203005503.141557-1-ebiggers@kernel.org
* https://lore.kernel.org/r/20230203010239.216421-1-ebiggers@kernel.org
- Eric
prev parent reply other threads:[~2023-02-03 1:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230129121851.2248378-1-willy@infradead.org>
[not found] ` <Y9a2m8uvmXmCVYvE@sol.localdomain>
[not found] ` <Y9a2m8uvmXmCVYvE-8Kz7deQLoS0mYvmMESoHnA@public.gmane.org>
2023-01-29 21:26 ` [PATCH] fscrypt: Copy the memcg information to the ciphertext page Matthew Wilcox
[not found] ` <Y9bkoasmAmtQ2nSV-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2023-01-31 21:27 ` Tejun Heo
[not found] ` <Y9mH0PCcZoGPryXw-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2023-02-01 6:31 ` Eric Biggers
2023-02-02 21:30 ` Tejun Heo
2023-02-03 1:07 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9xeTDOmMZ75G6cq@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox