From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH 6/7] mm: memcontrol: switch to rstat
Date: Thu, 4 Feb 2021 11:26:32 -0500 [thread overview]
Message-ID: <YBwgOHL8dTjJpnKU@cmpxchg.org> (raw)
In-Reply-To: <20210203014726.GE1812008-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
On Tue, Feb 02, 2021 at 05:47:26PM -0800, Roman Gushchin wrote:
> On Tue, Feb 02, 2021 at 01:47:45PM -0500, Johannes Weiner wrote:
> > for_each_node(node) {
> > struct mem_cgroup_per_node *pn = memcg->nodeinfo[node];
> > + unsigned long stat[NR_VM_NODE_STAT_ITEMS] = {0, };
> ^^
> I'd drop the comma here. It seems that "{0}" version is way more popular
> over the mm code and in the kernel in general.
Is there a downside to the comma? I'm finding more { 0, } than { 0 }
in mm code, and at least kernel-wide it seems both are acceptable
(although { 0 } is more popular overall).
I don't care much either way. I can change it in v2 if there is one.
next prev parent reply other threads:[~2021-02-04 16:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:47 [PATCH 0/7]: mm: memcontrol: switch to rstat Johannes Weiner
[not found] ` <20210202184746.119084-1-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-02 18:47 ` [PATCH 1/7] mm: memcontrol: fix cpuhotplug statistics flushing Johannes Weiner
2021-02-02 23:07 ` Roman Gushchin
[not found] ` <20210202230747.GA1812008-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2021-02-03 2:28 ` Roman Gushchin
[not found] ` <20210203022853.GG1812008-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2021-02-04 19:29 ` Johannes Weiner
[not found] ` <YBxLNZJ/83P7H8+H-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-04 19:34 ` Roman Gushchin
[not found] ` <20210204193446.GA2053875-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2021-02-05 17:50 ` Johannes Weiner
[not found] ` <20210202184746.119084-2-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-02 22:23 ` Shakeel Butt
2021-02-04 13:28 ` Michal Hocko
2021-02-02 18:47 ` [PATCH 2/7] mm: memcontrol: kill mem_cgroup_nodeinfo() Johannes Weiner
[not found] ` <20210202184746.119084-3-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-02 22:24 ` Shakeel Butt
2021-02-02 23:13 ` Roman Gushchin
2021-02-04 13:29 ` Michal Hocko
2021-02-02 18:47 ` [PATCH 3/7] mm: memcontrol: privatize memcg_page_state query functions Johannes Weiner
2021-02-02 22:26 ` Shakeel Butt
[not found] ` <20210202184746.119084-4-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-02 23:17 ` Roman Gushchin
2021-02-04 13:30 ` Michal Hocko
2021-02-02 18:47 ` [PATCH 4/7] cgroup: rstat: support cgroup1 Johannes Weiner
[not found] ` <20210202184746.119084-5-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-03 1:16 ` Roman Gushchin
2021-02-04 13:39 ` Michal Hocko
[not found] ` <YBv5Dc1I9QpPH69n-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-02-04 16:01 ` Johannes Weiner
[not found] ` <YBwaWkJgqPNF3I3w-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-04 16:42 ` Michal Hocko
2021-02-02 18:47 ` [PATCH 5/7] cgroup: rstat: punt root-level optimization to individual controllers Johannes Weiner
2021-02-02 18:47 ` [PATCH 6/7] mm: memcontrol: switch to rstat Johannes Weiner
[not found] ` <20210202184746.119084-7-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-03 1:47 ` Roman Gushchin
[not found] ` <20210203014726.GE1812008-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2021-02-04 16:26 ` Johannes Weiner [this message]
[not found] ` <YBwgOHL8dTjJpnKU-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-04 18:45 ` Roman Gushchin
[not found] ` <20210204184520.GC1837780-lLJQVQxiE4uLfgCeKHXN1g2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2021-02-04 20:05 ` Johannes Weiner
2021-02-04 14:19 ` Michal Hocko
2021-02-04 16:15 ` Johannes Weiner
[not found] ` <YBwdiu2Fj4JHgqhQ-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-04 16:44 ` Michal Hocko
[not found] ` <YBwkVoNa77Nn5TE9-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-02-04 20:28 ` Johannes Weiner
2021-02-05 15:05 ` Michal Hocko
[not found] ` <YB1esMKg3QhBDFG2-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-02-05 16:34 ` Johannes Weiner
[not found] ` <YB1zi/bZdeL2j59I-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-08 14:07 ` Michal Hocko
2021-02-02 18:47 ` [PATCH 7/7] mm: memcontrol: consolidate lruvec stat flushing Johannes Weiner
[not found] ` <20210202184746.119084-8-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-03 2:25 ` Roman Gushchin
[not found] ` <20210203022530.GF1812008-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2021-02-04 21:44 ` Johannes Weiner
[not found] ` <YBxquyq6XzWlV3Wv-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-04 21:47 ` Roman Gushchin
2021-02-05 15:17 ` Michal Hocko
[not found] ` <YB1hhwVybr0x5M2j-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-02-05 17:10 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBwgOHL8dTjJpnKU@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=guro-b10kYP2dOMg@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-IBi9RG/b67k@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).