From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Mark Rutland <mark.rutland@arm.com>, Pavel Machek <pavel@ucw.cz>,
Mike Snitzer <snitzer@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
kgdb-bugreport <kgdb-bugreport@lists.sourceforge.net>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Oleg Nesterov <oleg@redhat.com>, Ben Segall <bsegall@google.com>,
linux-mm <linux-mm@kvack.org>, dm-devel <dm-devel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Zefan Li <lizefan.x@bytedance.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Joel Fernandes, Google" <joel@joelfernandes.org>,
netdev <netdev@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Alasdair Kergon <agk@redhat.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
KVM list <kvm@vger.kernel.org>, Will Deacon <will@kernel.org>,
cgroups <cgroups@v>
Subject: Re: [PATCH 4/6] sched: Add get_current_state()
Date: Wed, 2 Jun 2021 16:12:30 +0200 [thread overview]
Message-ID: <YLeRzlEmbdsMrFcG@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1731339790.5856.1622642489232.JavaMail.zimbra@efficios.com>
On Wed, Jun 02, 2021 at 10:01:29AM -0400, Mathieu Desnoyers wrote:
> ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote:
>
> > Remove yet another few p->state accesses.
>
> [...]
>
> >
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -212,6 +212,8 @@ struct task_group;
> >
> > #endif
> >
> > +#define get_current_state() READ_ONCE(current->state)
>
> Why use a macro rather than a static inline here ?
Mostly to be consistent, all that state stuff is macros. I suppose we
could try and make them inlines at the end or so -- if the header maze
allows.
next prev parent reply other threads:[~2021-06-02 14:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:12 [PATCH 0/6] sched: Cleanup task_struct::state Peter Zijlstra
2021-06-02 13:12 ` [PATCH 1/6] sched: Unbreak wakeups Peter Zijlstra
2021-06-02 13:58 ` Greg Kroah-Hartman
[not found] ` <20210602133040.271625424-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2021-06-02 14:47 ` Will Deacon
2021-06-02 19:43 ` Davidlohr Bueso
2021-06-02 13:12 ` [PATCH 2/6] sched: Introduce task_is_running() Peter Zijlstra
2021-06-02 14:59 ` Will Deacon
2021-06-02 16:46 ` Peter Zijlstra
2021-06-02 23:15 ` Davidlohr Bueso
2021-06-02 13:12 ` [PATCH 3/6] sched,perf,kvm: Fix preemption condition Peter Zijlstra
2021-06-02 13:59 ` Mathieu Desnoyers
2021-06-02 14:10 ` Peter Zijlstra
[not found] ` <YLeRVQbXt2hCiO8f-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2021-06-02 14:30 ` Mark Rutland
[not found] ` <20210602133040.398289363-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2021-06-02 14:15 ` Mathieu Desnoyers
2021-06-02 14:23 ` Peter Zijlstra
2021-06-02 13:12 ` [PATCH 4/6] sched: Add get_current_state() Peter Zijlstra
[not found] ` <20210602133040.461908001-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2021-06-02 14:01 ` Mathieu Desnoyers
2021-06-02 14:12 ` Peter Zijlstra [this message]
2021-06-02 15:02 ` Will Deacon
2021-06-02 13:12 ` [PATCH 5/6] sched,timer: Use __set_current_state() Peter Zijlstra
[not found] ` <20210602133040.524487671-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2021-06-02 15:06 ` Will Deacon
2021-06-02 19:54 ` Davidlohr Bueso
2021-06-03 6:39 ` Peter Zijlstra
2021-06-18 20:42 ` Thomas Gleixner
2021-06-02 13:12 ` [PATCH 6/6] sched: Change task_struct::state Peter Zijlstra
[not found] ` <20210602133040.587042016-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2021-06-02 14:06 ` Mathieu Desnoyers
2021-06-02 14:20 ` Peter Zijlstra
2021-06-02 15:10 ` Will Deacon
2021-06-07 10:45 ` Daniel Thompson
[not found] ` <20210607104500.sopvslejuoxwzhrs-DWWWtol72k3/PtFMR13I2A@public.gmane.org>
2021-06-07 11:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLeRzlEmbdsMrFcG@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=agk@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bsegall@google.com \
--cc=cgroups@v \
--cc=daniel.thompson@linaro.org \
--cc=dave@stgolabs.net \
--cc=dm-devel@redhat.com \
--cc=hpa@zytor.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=jolsa@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pavel@ucw.cz \
--cc=pbonzini@redhat.com \
--cc=snitzer@redhat.com \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox