public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
To: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	alexs-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true
Date: Thu, 29 Jul 2021 20:07:27 -0700	[thread overview]
Message-ID: <YQNs71JoXrxTnAA8@carbon.lan> (raw)
In-Reply-To: <20210729125755.16871-4-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Thu, Jul 29, 2021 at 08:57:53PM +0800, Miaohe Lin wrote:
> Add 'else' to save some atomic ops in obj_stock_flush_required() when
> flush is already true. No functional change intended here.
> 
> Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

Acked-by: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>

  parent reply	other threads:[~2021-07-30  3:07 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 12:57 [PATCH 0/5] Cleanups and fixup for memcontrol Miaohe Lin
2021-07-29 12:57 ` [PATCH 1/5] mm, memcg: remove unused functions Miaohe Lin
     [not found]   ` <20210729125755.16871-2-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-07-29 14:07     ` Shakeel Butt
2021-07-30  2:39     ` Muchun Song
2021-07-30  2:57     ` Roman Gushchin
2021-07-30  6:45     ` Michal Hocko
2021-07-29 12:57 ` [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true Miaohe Lin
     [not found]   ` <20210729125755.16871-4-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-07-29 14:40     ` Shakeel Butt
2021-07-30  2:37     ` Muchun Song
2021-07-30  3:07     ` Roman Gushchin [this message]
2021-07-30  6:51     ` Michal Hocko
     [not found] ` <20210729125755.16871-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-07-29 12:57   ` [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex Miaohe Lin
     [not found]     ` <20210729125755.16871-3-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-07-30  2:42       ` Muchun Song
2021-07-30  3:06       ` Roman Gushchin
     [not found]         ` <YQNsxVPsRSBZcfGG-esYZh5BkUNV+urZeOPWqwQ@public.gmane.org>
2021-07-30  6:50           ` Michal Hocko
     [not found]             ` <YQOhGs3k9rHx3mmT-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-07-31  2:29               ` Miaohe Lin
     [not found]                 ` <4a3c23c4-054c-2896-29c5-8cf9a4deee98-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-08-02  6:49                   ` Michal Hocko
     [not found]                     ` <YQeVYLP6M9tMw0P0-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-08-02  9:54                       ` Miaohe Lin
2021-08-03  3:40                   ` Roman Gushchin
     [not found]                     ` <YQi6lOT6j2DtOGlT-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2021-08-03  6:29                       ` Miaohe Lin
     [not found]                         ` <95629d91-6ae8-b445-e7fc-b51c888cad59-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-08-03  7:11                           ` Michal Hocko
     [not found]                             ` <YQjsHTW+46bG9XsV-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-08-03  7:13                               ` Roman Gushchin
     [not found]                                 ` <898130C3-FDF2-41C2-81DD-D33721C977C6-b10kYP2dOMg@public.gmane.org>
2021-08-03  7:27                                   ` Michal Hocko
2021-08-03  9:33                           ` Muchun Song
     [not found]                             ` <CAMZfGtUChsJO1UrgmP6M274UwiHap0_yzCBL+mDq1OosP7JNsA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-08-03 10:50                               ` Miaohe Lin
2021-08-03 14:15               ` Johannes Weiner
     [not found]                 ` <YQlPiLY0ieRb704V-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-08-04  8:20                   ` Michal Hocko
     [not found]                     ` <YQpNtfjl0rHH8Mgf-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-08-05  1:44                       ` Miaohe Lin
2021-07-30  6:46     ` Michal Hocko
2021-07-29 12:57   ` [PATCH 4/5] mm, memcg: avoid possible NULL pointer dereferencing in mem_cgroup_init() Miaohe Lin
     [not found]     ` <20210729125755.16871-5-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-07-29 13:52       ` Matthew Wilcox
     [not found]         ` <YQKyn8bKRblCDuND-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2021-07-30  1:50           ` Miaohe Lin
2021-07-30  3:12       ` Roman Gushchin
2021-07-30  6:29         ` Miaohe Lin
     [not found]         ` <YQNuK+jN7pZLJTvT-esYZh5BkUNV+urZeOPWqwQ@public.gmane.org>
2021-07-30  6:44           ` Michal Hocko
2021-07-31  2:05             ` Miaohe Lin
     [not found]               ` <f7a22702-cd08-6b15-48c7-68523c38060b-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-08-02  6:43                 ` Michal Hocko
2021-08-02 10:00                   ` Miaohe Lin
     [not found]                     ` <47daf062-f510-edb3-6ec7-f8e7615ad8a0-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-08-02 10:42                       ` Michal Hocko
     [not found]                         ` <YQfMISKHetFOm1Kx-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-08-02 11:18                           ` Miaohe Lin
2021-07-29 12:57   ` [PATCH 5/5] mm, memcg: always call __mod_node_page_state() with preempt disabled Miaohe Lin
     [not found]     ` <20210729125755.16871-6-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-07-29 14:39       ` Shakeel Butt
     [not found]         ` <CALvZod6n1EwcyLTi=Eb8t=NVVPLRh9=Ng=VJ93pQyCRkOcLo9Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-07-30  1:52           ` Miaohe Lin
     [not found]             ` <29c4bb2a-ceaf-6c8b-c222-38b30460780f-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2021-07-30  2:33               ` [External] " Muchun Song
     [not found]                 ` <CAMZfGtUMBZeo-P48MECO=xM9-apeLMAZZGE3VNsg_u5P523BEg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-07-30  2:46                   ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQNs71JoXrxTnAA8@carbon.lan \
    --to=guro-b10kyp2domg@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=alexs-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox