From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Vishal Verma <vverma-tWEdnPwa2b6ifxm/DiOjgA@public.gmane.org>
Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: cgroup-v1: do not exclude cgrp_dfl_root
Date: Tue, 5 Oct 2021 06:14:23 -1000 [thread overview]
Message-ID: <YVx5342KvJ1RFoL+@slm.duckdns.org> (raw)
In-Reply-To: <20211004201948.20293-1-vverma-tWEdnPwa2b6ifxm/DiOjgA@public.gmane.org>
On Mon, Oct 04, 2021 at 08:19:48PM +0000, Vishal Verma wrote:
> Found an issue within cgroup_attach_task_all() fn which seem
> to exclude cgrp_dfl_root (cgroupv2) while attaching tasks to
> the given cgroup. This was noticed when the system was running
> qemu/kvm with kernel vhost helper threads. It appears that the
> vhost layer which uses cgroup_attach_task_all() fn to assign the
> vhost kthread to the right qemu cgroup works fine with cgroupv1
> based configuration but not in cgroupv2. With cgroupv2, the vhost
> helper thread ends up just belonging to the root cgroup as is
> shown below:
...
> Suggested-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Vishal Verma <vverma-tWEdnPwa2b6ifxm/DiOjgA@public.gmane.org>
Applied to cgroup/for-5.16.
Thanks.
--
tejun
prev parent reply other threads:[~2021-10-05 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 20:19 [PATCH] cgroup: cgroup-v1: do not exclude cgrp_dfl_root Vishal Verma
[not found] ` <20211004201948.20293-1-vverma-tWEdnPwa2b6ifxm/DiOjgA@public.gmane.org>
2021-10-05 16:14 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVx5342KvJ1RFoL+@slm.duckdns.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=vverma-tWEdnPwa2b6ifxm/DiOjgA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox