From: Mike Rapoport <rppt@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com,
vbabka@suse.cz, willy@infradead.org, songmuchun@bytedance.com,
shy828301@gmail.com, surenb@google.com,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/4] mm/memcg: mem_cgroup_per_node is already set to 0 on allocation
Date: Fri, 14 Jan 2022 13:08:28 +0200 [thread overview]
Message-ID: <YeFZrEAaPw1Y5wwd@kernel.org> (raw)
In-Reply-To: <20220111010302.8864-2-richard.weiyang@gmail.com>
On Tue, Jan 11, 2022 at 01:03:00AM +0000, Wei Yang wrote:
> kzalloc_node() would set data to 0, so it's not necessary to set it
> again.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> mm/memcontrol.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 11715f7323c0..a504616f904a 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5067,8 +5067,6 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node)
> }
>
> lruvec_init(&pn->lruvec);
> - pn->usage_in_excess = 0;
> - pn->on_tree = false;
> pn->memcg = memcg;
>
> memcg->nodeinfo[node] = pn;
> --
> 2.33.1
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2022-01-14 11:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 1:02 [PATCH 1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node Wei Yang
2022-01-11 1:03 ` [PATCH 2/4] mm/memcg: mem_cgroup_per_node is already set to 0 on allocation Wei Yang
[not found] ` <20220111010302.8864-2-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-01-11 2:25 ` Muchun Song
2022-01-11 18:06 ` Roman Gushchin
2022-01-16 19:24 ` Shakeel Butt
2022-01-11 8:41 ` Michal Hocko
2022-01-14 11:08 ` Mike Rapoport [this message]
[not found] ` <20220111010302.8864-1-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-01-11 1:03 ` [PATCH 3/4] mm/memcg: retrieve parent memcg from css.parent Wei Yang
2022-01-11 8:43 ` Michal Hocko
[not found] ` <20220111010302.8864-3-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-01-11 3:12 ` Muchun Song
2022-01-11 18:09 ` Roman Gushchin
[not found] ` <Yd3H8Hea6dBlkzeW-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2022-01-12 0:24 ` Wei Yang
2022-01-16 19:54 ` Shakeel Butt
2022-01-11 1:03 ` [PATCH 4/4] mm/memcg: refine mem_cgroup_threshold_ary->current_threshold calculation Wei Yang
2022-01-11 8:44 ` Michal Hocko
[not found] ` <20220111010302.8864-4-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-01-11 18:23 ` Roman Gushchin
[not found] ` <Yd3LLalWzPy17PmR-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2022-01-12 0:25 ` Wei Yang
2022-01-11 2:23 ` [PATCH 1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node Muchun Song
2022-01-11 8:40 ` Michal Hocko
[not found] ` <Yd1CdJA5NelzoK1D-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-01-12 0:46 ` Wei Yang
2022-01-12 8:56 ` Michal Hocko
[not found] ` <Yd6Xr7K9bKGVgGtI-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-01-14 0:29 ` Wei Yang
2022-01-14 8:51 ` Michal Hocko
[not found] ` <YeE5k79uP3xBPCv7-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-01-15 22:10 ` Wei Yang
2022-01-16 19:23 ` Shakeel Butt
2022-01-11 18:05 ` Roman Gushchin
2022-01-14 11:07 ` Mike Rapoport
2022-01-31 1:47 ` Wei Yang
2022-01-31 22:36 ` Andrew Morton
[not found] ` <20220131143620.b619f24f5246b26bce2b717d-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2022-02-01 0:42 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeFZrEAaPw1Y5wwd@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).