From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Rientjes <rientjes@google.com>
Cc: Waiman Long <longman@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Ira Weiny <ira.weiny@intel.com>,
Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size
Date: Mon, 31 Jan 2022 12:25:09 +0200 [thread overview]
Message-ID: <Yfe5Bb3U6Uil7Y6g@smile.fi.intel.com> (raw)
In-Reply-To: <d99b3c4b-7b6e-529-6e4b-b91b65c92d81@google.com>
On Sun, Jan 30, 2022 at 12:49:37PM -0800, David Rientjes wrote:
> On Sat, 29 Jan 2022, Waiman Long wrote:
>
> > For *scnprintf(), vsnprintf() is always called even if the input size is
> > 0. That is a waste of time, so just return 0 in this case.
Why do you think it's not legit?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-31 10:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 20:53 [PATCH v2 0/3] mm/page_owner: Extend page_owner to show memcg information Waiman Long
[not found] ` <20220129205315.478628-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-29 20:53 ` [PATCH v2 1/3] lib/vsprintf: Avoid redundant work with 0 size Waiman Long
[not found] ` <20220129205315.478628-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-30 20:49 ` David Rientjes
[not found] ` <d99b3c4b-7b6e-529-6e4b-b91b65c92d81-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-01-30 20:57 ` Waiman Long
2022-01-31 10:25 ` Andy Shevchenko [this message]
2022-01-31 10:30 ` Andy Shevchenko
[not found] ` <Yfe6SfG4CqzWSaMM-XvqNBM/wLWRrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2022-01-31 10:34 ` Andy Shevchenko
2022-01-31 11:02 ` Rasmus Villemoes
[not found] ` <d44824d4-2dd1-a8ab-d3ee-ac67b749ca6f-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2022-01-31 11:22 ` Andy Shevchenko
2022-01-31 18:48 ` Waiman Long
[not found] ` <c33b6435-1b27-32af-b14c-0f3a0318dcca-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-02-01 7:12 ` Rasmus Villemoes
[not found] ` <f3bcf541-e77b-ca93-ef5c-862f4de99366-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2022-02-01 16:01 ` Waiman Long
2022-01-31 2:53 ` Sergey Senozhatsky
2022-01-31 18:17 ` Roman Gushchin
2022-01-29 20:53 ` [PATCH v2 2/3] mm/page_owner: Use scnprintf() to avoid excessive buffer overrun check Waiman Long
[not found] ` <20220129205315.478628-3-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-31 2:58 ` Sergey Senozhatsky
2022-01-29 20:53 ` [PATCH v2 3/3] mm/page_owner: Dump memcg information Waiman Long
[not found] ` <20220129205315.478628-4-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-30 6:33 ` Mike Rapoport
2022-01-30 18:22 ` Waiman Long
[not found] ` <82c99093-e44b-7fac-14ab-9e8392d107ea-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-01-30 20:51 ` David Rientjes
2022-01-31 9:38 ` Michal Hocko
[not found] ` <YfeuK5j7cbgM+Oo+-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-01-31 16:53 ` Johannes Weiner
[not found] ` <YfgT/9tEREQNiiAN-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-01-31 18:15 ` Roman Gushchin
[not found] ` <YfgnUZQBRkqhrEIb-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2022-01-31 18:25 ` Michal Hocko
[not found] ` <Yfgpknwr1tMnPkqh-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-01-31 18:38 ` Waiman Long
[not found] ` <12686956-612d-d89b-5641-470d5e913090-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-02-01 10:49 ` Michal Hocko
2022-02-01 16:41 ` Waiman Long
[not found] ` <268a8bdf-4c70-b967-f34c-2293b54186f0-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-02-02 8:57 ` Michal Hocko
[not found] ` <YfpHbtffFi2x1L4p-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-02-02 15:54 ` Roman Gushchin
2022-02-02 16:38 ` Michal Hocko
[not found] ` <YfqzbwAPKpshXSLK-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-02-02 17:51 ` Roman Gushchin
[not found] ` <YfrEpOGObnc0mYAW-cx5fftMpWqeCjSd+JxjunQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2022-02-02 17:56 ` Michal Hocko
2022-02-02 16:29 ` Waiman Long
2022-01-31 19:01 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfe5Bb3U6Uil7Y6g@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).