From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Igor Zhbanov <i.zhbanov-4G3FwjhnV40EXkLx5dDeUA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] mm/memcontrol: return 1 from cgroup.memory __setup() handler
Date: Thu, 3 Mar 2022 23:32:32 +0100 [thread overview]
Message-ID: <YiFCAFZwG//aeQP2@blackbook> (raw)
In-Reply-To: <5130da56-0f22-8212-0ea3-6ddb8a8f5455-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Thu, Mar 03, 2022 at 01:53:03PM -0800, Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
> > Isn't mere presence of the handler sufficient to filter those out? [1]
>
> What is [1] here?
Please ignore, too much editing on my side.
> I don't know of any case where "foo=2" should be passed to init if
> there is a setup function for "foo=" defined.
Good. I was asking because of the following semantics:
- absent handler -- pass to init,
- returns 0 -- filter out,
- returns negative -- filter out, print message.
> > (Richer reporting or -EINVAL is by my understanding now a different
> > problem.)
Regards,
Michal
next prev parent reply other threads:[~2022-03-03 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 0:58 [PATCH 1/2] mm/memcontrol: return 1 from cgroup.memory __setup() handler Randy Dunlap
[not found] ` <20220222005811.10672-1-rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-03-02 18:53 ` Michal Koutný
[not found] ` <20220302185300.GA19699-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-03-03 0:53 ` Randy Dunlap
[not found] ` <9f8d4ddb-81ce-738a-d1f7-346ff9bf8ebd-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-03-03 10:14 ` Michal Koutný
[not found] ` <20220303101406.GE10867-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-03-03 21:53 ` Randy Dunlap
[not found] ` <5130da56-0f22-8212-0ea3-6ddb8a8f5455-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-03-03 22:32 ` Michal Koutný [this message]
2022-03-03 22:53 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiFCAFZwG//aeQP2@blackbook \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=i.zhbanov-4G3FwjhnV40EXkLx5dDeUA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox